Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behavior of :find [(pull ... is under-defined and has changed recently #71

Open
deg opened this issue Apr 24, 2017 · 0 comments
Open

Behavior of :find [(pull ... is under-defined and has changed recently #71

deg opened this issue Apr 24, 2017 · 0 comments

Comments

@deg
Copy link
Contributor

deg commented Apr 24, 2017

The behavior of a Vase pull query does not seem to be fully defined.
Worse, it has recently changed incompatibly somewhere between Vase commits 8f61d36 and bf96190.

In the old version :find [(pull ?e [*]) ...] returned the tuples wrapped in an extra layer of vector.
This extra wrapping no longer occurs. FWIW, the new behavior seems more sensible, but the change breaks client code.

Also, surprising at least to me, a simpler :find (pull ?e [*]) returned a more complex structure. Prior to the recent changes, if I recall correctly, there were two extra layers. I've not tested what is returned in the latest version.

Suggestions:

  1. Document the interactions between pull and Vase, and the expected values. Some additional tests would be good too. The code is likely fragile, given that the current change appears to have been introduced accidentally.
  2. Warn that the behavior has changed, in the 0.9.1 release notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant