Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Woomer breaks tiling of fullscreen / maximized windows #5

Open
jacekpoz opened this issue May 27, 2024 · 9 comments
Open

Woomer breaks tiling of fullscreen / maximized windows #5

jacekpoz opened this issue May 27, 2024 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@jacekpoz
Copy link
Contributor

opening woomer on a workspace with a fullscreen / maximized window un-fullscreens it - after closing woomer they're back to normal tiling

not sure how to fix this, it'd be great if you found a way

@coffeeispower
Copy link
Owner

This is a thing I think I can't really fix because woomer opens a fullscreen window and you can't have 2 fullscreen windows on the same workspace.

@jacekpoz
Copy link
Contributor Author

one idea I had was to check if the active window's fullscreen is true, if that's the case fullscreening it again after the woomer window is closed but that's really hacky

what about making woomer a layer_surface?

@coffeeispower
Copy link
Owner

coffeeispower commented May 27, 2024

I'm not sure if glfw supports opening layers instead of windows.
The only way this could be done is if i can convert the glfw window into a layer somehow

@coffeeispower coffeeispower added bug Something isn't working labels May 27, 2024
@coffeeispower coffeeispower self-assigned this May 27, 2024
@Shinyzenith
Copy link

To fix this issue, would you accept a pr that optionally creates a egl backend from scratch with layer shell?

@coffeeispower
Copy link
Owner

coffeeispower commented May 28, 2024

@Shinyzenith I'm not sure because that would conflict with #9 , i would prefer to keep raylib, but if it has to be done i wouldn't mind too much losing support for a niche operating system for video games because the main focus of this project is wayland.

But that would require to literally rewrite woomer from scratch... And maybe increase the amount of code from a few hundreds to probably a thousand lines.

It seems also that gnome doesn't support the layer protocol sooo...

This makes me think about if it's worth missing out a lot on compatibility for just not making fullscreen apps get out of fullscreen mode when woomer is opened, you can just put the application back in fullscreen mode

@coffeeispower
Copy link
Owner

Let's see if raysan says something on my issue, i really hope so

@coffeeispower
Copy link
Owner

coffeeispower commented May 28, 2024

Got an idea, i can pull up the glfw window handle from raylib, than pull the wayland surface and then convert it into a layer, what do you think? do you think this will work?

@Shinyzenith
Copy link

I am unsure...I'll test out my PoC before I speak further

@coffeeispower
Copy link
Owner

coffeeispower commented May 29, 2024

We got good news, it seems like raysan would accept a PR adding support for layer surfaces on raylib: raysan5/raylib#4009 (comment)
So fortunately we will have this issue fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants