add more tests and prove it

Author: codyoss

.drone.yml

@@ -0,0 +1,11 @@
+workspace:
+  base: /go
+  path: src/github.com/codyoss/retry
+
+pipeline:
+  test:
+    image: golang:1.11-stretch
+    secrets: [ CODECOV_TOKEN ]
+    commands:
+      - go test -race -coverprofile=coverage.txt -covermode=atomic
+      - curl -s https://codecov.io/bash > .codecov && chmod +x .codecov && ./.codecov

.gitignore

@@ -11,6 +11,8 @@
 
 # Test binary, build with `go test -c`
 *.test
+coverage.txt
+.codecov
 
 # Output of the go coverage tool, specifically when used with LiteIDE
 *.out

README.md

@@ -3,6 +3,8 @@
 retry is a package that enables retrying code.
 
 [![GoDoc](https://godoc.org/github.com/codyoss/retry?status.svg)](https://godoc.org/github.com/codyoss/retry)
+[![Build Status](https://cloud.drone.io/api/badges/codyoss/retry/status.svg)](https://cloud.drone.io/codyoss/retry)
+[![codecov](https://codecov.io/gh/codyoss/retry/branch/master/graph/badge.svg)](https://codecov.io/gh/codyoss/retry)
 [![Go Report Card](https://goreportcard.com/badge/github.com/codyoss/retry)](https://goreportcard.com/report/github.com/codyoss/retry)
 
 It has:

retry_internal_test.go

@@ -42,3 +42,32 @@ func TestFreezeBackoffAfterFirstUse(t *testing.T) {
 		t.Error("public fields should change, private should have been frozen")
 	}
 }
+
+func TestFreezeBackoffWithBadInputs(t *testing.T) {
+	attempts := -1
+	initialDelay := -1 * time.Millisecond
+	maxDelay := 0 * time.Millisecond
+	factor := 0.0
+	jitter := -1.0
+
+	b := &Backoff{
+		Attempts:     attempts,
+		InitialDelay: initialDelay,
+		MaxDelay:     maxDelay,
+		Factor:       factor,
+		Jitter:       jitter,
+	}
+
+	It(b, func() error {
+		return nil
+	})
+
+	if b.attempts != 1 ||
+		b.initialDelay != 0 ||
+		b.maxDelay != Forever ||
+		b.factor != 1 ||
+		b.jitter != 0 ||
+		b.skipJitter != true {
+		t.Error("public fields should change, private should have been frozen")
+	}
+}

retry_test.go

@@ -29,6 +29,7 @@ func TestIt(t *testing.T) {
 		wantErr error
 	}{
 		{"works", &retry.Backoff{Attempts: 3, Factor: 1.0, InitialDelay: 1 * time.Millisecond, MaxDelay: retry.Forever, Jitter: .1}, "It Worked", nil},
+		{"works, uses maxDelay", &retry.Backoff{Attempts: 3, Factor: 2.0, InitialDelay: 1 * time.Millisecond, MaxDelay: 2 * time.Millisecond, Jitter: .1}, "It Worked", nil},
 		{"not work, no retries", &retry.Backoff{Attempts: 1, Factor: 1.0, InitialDelay: 500 * time.Millisecond, MaxDelay: retry.Forever, Jitter: .1}, "", retry.Me},
 		{"not work, one retry", &retry.Backoff{Attempts: 2, Factor: 1.0, InitialDelay: 1 * time.Millisecond, MaxDelay: retry.Forever, Jitter: .1}, "", retry.Me},
 	}
@@ -65,6 +66,7 @@ func TestItContext(t *testing.T) {
 		wantErr  error
 	}{
 		{"works", &retry.Backoff{Attempts: 3, Factor: 1.0, InitialDelay: 1 * time.Millisecond, MaxDelay: retry.Forever, Jitter: .1}, 10 * time.Millisecond, "It Worked", nil},
+		{"works, uses maxDelay", &retry.Backoff{Attempts: 3, Factor: 2.0, InitialDelay: 1 * time.Millisecond, MaxDelay: 2 * time.Millisecond, Jitter: .1}, 10 * time.Millisecond, "It Worked", nil},
 		{"not work, no retries", &retry.Backoff{Attempts: 1, Factor: 1.0, InitialDelay: 500 * time.Millisecond, MaxDelay: retry.Forever, Jitter: .1}, 10 * time.Millisecond, "", retry.Me},
 		{"not work, one retry", &retry.Backoff{Attempts: 2, Factor: 1.0, InitialDelay: 1 * time.Millisecond, MaxDelay: retry.Forever, Jitter: .1}, 10 * time.Millisecond, "", retry.Me},
 		{"not work, deadline exceeded", retry.ExponentialBackoff, 10 * time.Millisecond, "", context.DeadlineExceeded},