Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean claim inputs #391

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

YashKumarVerma
Copy link
Contributor

Fixes #390

I believed that it was a simple task to just remove the slashes from the URLs, however it later transformed to fixing the issues in all URLs submitted during BOSS ❤️


What's done

  • Entire live data parsed, and after processing each and every issueUrl and pullUrl submitted, and all types of errors in the URLs were listed down.
  • However it was found on observation that some URLs which were submitted were of comments, few were incomplete
    • One URL https://github.com/coding-blocks/gondor was pointing to a project.
    • ID: 800 by user rajdeep1363 This is fixed in the script.
    • One URL has link to issues page https://github.com/coding-blocks/make-a-pr/issues. Fixed in the script.
  • Few claims need to be deleted as they are of the same issue/pr pair, and differ only by a hash sign or extra space.
    • https://github.com/coding-blocks/gondor/pull/61
    • https://github.com/coding-blocks/boss/pull/308#issuecomment-633161908
    • check the fixing script for more.

Preparing for future

  • A utility function added
  • This function takes care of the following things
    • Handle extra spacing in starting and end
      • One case detected, fixed, check added
    • Extract issue link from comment links
      • Multiple cases detected, fixed, check added
    • Handle extra slashes
      • No Case detected, check added
    • Handle case when multiple URLs submitted in single column
      • ID: 1004, by user shivamgohri : multiple URLs submitted in one column
      • check added

Handling the past

  • A simple script is created to fix the errors that happened in the past.
  • The script is to be run from the root of the project, as it depends on the stored credentials of the database.
  • It will create a file named error.txt if any errors are encountered, with the ID of the record which created the error.

Listing all conflicts:

[issueUrl]
https://github.com/coding-blocks/CBOnlineApp/issues/694#issue-618082019
https://github.com/coding-blocks/CBOnlineApp/issues/720#issue-618976425
https://github.com/coding-blocks/CBOnlineApp/issues/770  https://github.com/coding-blocks/CBOnlineApp/issues/772
https://github.com/coding-blocks/boss/issues/243#issue-619455997
https://github.com/coding-blocks/gondor
https://github.com/coding-blocks/make-a-pr/issues

[pullUrl]
https://github.com/coding-blocks/CBOnlineApp/issues/694#issue-618082019
https://github.com/coding-blocks/CBOnlineApp/pull/805#issue-419779633
https://github.com/coding-blocks/boss/issues/243#issue-619455997
https://github.com/coding-blocks/boss/pull/308#issuecomment-633161908

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure new claims do not send non-standard inputs
1 participant