Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure to check if checkPassword() calls checkPasswordRules(). #521

Open
WojAbuk opened this issue May 27, 2021 · 3 comments
Open

Failure to check if checkPassword() calls checkPasswordRules(). #521

WojAbuk opened this issue May 27, 2021 · 3 comments

Comments

@WojAbuk
Copy link

WojAbuk commented May 27, 2021

I had to say that the checkPasswordRules () function returns Ok, but after analyzing it, I see that the error is in checkPassword(). Hardly returns Ok.

@ziobron
Copy link
Contributor

ziobron commented May 27, 2021

🏅 2 XP granted for @WojAbuk
Thanks for raising this Issue to help to make the course better!

@ziobron
Copy link
Contributor

ziobron commented May 27, 2021

It is not important right now to have this check, but I'll leave this issue for reference. I need to check if Google Mock can be used to achieve that.
BTW can you provide a link with the example that is problematic?

@WojAbuk
Copy link
Author

WojAbuk commented May 28, 2021

I can't (nie potrafię) send a link to an older version of the code than the newest on github. This is in my repository. https://github.com/WojAbuk/cpp-fundamentals/blob/password-check/homework/password-check/validation.cpp Here is a revised version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants