Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Title Logging Config Setting #274

Open
nmccamish opened this issue Jan 25, 2025 · 4 comments
Open

[FEAT] Title Logging Config Setting #274

nmccamish opened this issue Jan 25, 2025 · 4 comments
Labels

Comments

@nmccamish
Copy link

I know I can turn on title logging with pyradio -lt or press W, but I would like if there was a setting where I could set a default. As an alternative, I currently have a bash alias.

@s-n-g
Copy link
Collaborator

s-n-g commented Jan 25, 2025

Hi @nmccamish

I always intended to do that, but just keep forgetting...
Thanks for the heads-up!

@s-n-g
Copy link
Collaborator

s-n-g commented Jan 26, 2025

Done in devel

If you want to test it, download my devel package: pyradio devel, unzip it and execute

./devel/build_install_pyradio

@nmccamish
Copy link
Author

It seems to work, although https://github.com/s-n-g/pyradio/blob/41b45b0d6c4bfb0ed2d23234ca7c1d909c1cb96e/pyradio/config#L125-L126 looks contradictory. Is log_titles supposed to be False or True by default?

@s-n-g
Copy link
Collaborator

s-n-g commented Jan 31, 2025

Yeah, I did it again! :)

The value should have been False, the documentation is correct, I just forgot to revert to the default before pushing it...

I will do so before the next release...

I appreciate you pointing this out again!

@s-n-g s-n-g added the bug label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants