Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyRadio AM Theme #202

Closed
amski1 opened this issue Sep 19, 2023 · 24 comments
Closed

PyRadio AM Theme #202

amski1 opened this issue Sep 19, 2023 · 24 comments

Comments

@amski1
Copy link

amski1 commented Sep 19, 2023

A little theme I spent some time creating.

AM.zip

@s-n-g
Copy link
Collaborator

s-n-g commented Sep 19, 2023

Nice one!

Renamed it to "AM_by_amski1", hope you don't mind.
Will be included in the next release

Here it is with Calculated color = 0.02

Mabox_20230919-21-56-38

@amski1
Copy link
Author

amski1 commented Sep 19, 2023

Don't mind at all. I'd be honored.

What's a "calculated color"?

The dark green looks slightly different on Windows than it does on Linux, but I guess it depends on the monitor's color profile...

@s-n-g
Copy link
Collaborator

s-n-g commented Sep 19, 2023

Don't mind at all. I'd be honored.

All mine!
Thank you for contributing! :)

What's a "calculated color"?

Mabox_20230919-22-09-13

It's this config setting...

The dark green looks slightly different on Windows than it does on Linux, but I guess it depends on the monitor's color profile...

Yes...
That sounds right 😉

@amski1
Copy link
Author

amski1 commented Sep 19, 2023

I see. I left the house, but when I'm back I'll check what's on my side. If the calculated color occurs or not.

It appears easy, but in reality it's pretty hard to pick a good set of colors. I started making the theme and then it hit me... oh, this will take a while 😂

@s-n-g
Copy link
Collaborator

s-n-g commented Sep 19, 2023

😂
I know, playing with colors is so fun!

You can make all the changes you think necessary, even after it has been released, we can still update it in a future release

BTW, why don't you experiment with transparency as well?

# Theme Transparency
# Values are:
#   0: No transparency (default)
#   1: Theme is transparent
#   2: Obey config setting
transparency        0

Setting transparency to 2, and pressing "T" will enable it...
I think a "dark" theme (like yours) would look good with transparency ON

@amski1
Copy link
Author

amski1 commented Sep 19, 2023

I think that on Windows it's not possible to get transparency in CMD (just checked, it goes to black). Would have to go with the new terminal, which seems... heavy to say the least.

If it's required then I'll do it. Don't mind it.

@s-n-g
Copy link
Collaborator

s-n-g commented Sep 19, 2023

This is on Window 11, Powershell (transparency set to 85%, pressing "T", after changing transparency to 2 in the theme)

win11-transparency.mp4

And here's the settings

win11-transparency

You will get similar result on *Windows 10 with Powershell.

Looking into Windows7 as well

@amski1
Copy link
Author

amski1 commented Sep 19, 2023

True, works good on PowerShell

@s-n-g
Copy link
Collaborator

s-n-g commented Sep 19, 2023

Have you enabled transparency then?
You are on 10 or 11?
No need to look for a Windows 7 solution?

@amski1
Copy link
Author

amski1 commented Sep 19, 2023

W10. Yes, on PowerShell and it looks fine with the theme set to 2. When you hold CTRL, SHIFT and scroll the mouse wheel, the transparency changes on the fly.

@s-n-g
Copy link
Collaborator

s-n-g commented Sep 19, 2023

Things are a bit different on linux and mac though

With Powershell on windows, you get the transparency because of the window transparency, without having to press "T".

If you do press "T" on Windows, you will see what a linux (or mac) user will see when transparency is no (well, almost). Do you still think it's ok?

Watch the video above to see what I mean 😉

Or just open pyradio in CMD and press "T", same effect (pyradio's background color dissapears)

@amski1
Copy link
Author

amski1 commented Sep 19, 2023

I know. It doesn't honor transparency with T, becomes black. Transparency in CMD and PowerShell on W10 seems to be adjustable on the system GUI level, separate from what's drawn inside the command prompt.

@amski1
Copy link
Author

amski1 commented Sep 23, 2023

How it looks on my end:

vsdc-sr.2023-09-23.11-47-41.mp4

@amski1
Copy link
Author

amski1 commented Sep 23, 2023

Is it possible to have the now-playing station in bold font?

@s-n-g
Copy link
Collaborator

s-n-g commented Sep 23, 2023

Is it possible to have the now-playing station in bold font?

No, not at the moment, and I think it may be too complicated to achieve (not all terminals support bold, I think)
I will have to look into it...

@s-n-g
Copy link
Collaborator

s-n-g commented Oct 4, 2023

The theme is part of Version 0.9.2.14
Thanks for the contribution!
Closing...

@s-n-g s-n-g closed this as completed Oct 4, 2023
@amski1
Copy link
Author

amski1 commented Oct 4, 2023

😍

@amski1
Copy link
Author

amski1 commented Jan 5, 2025

I apologize to post within this old thread, but I'd rather avoid opening a new one. Please see if this theme is worthy of anything. I called it λambda (Lambda).

λambda.zip

@s-n-g
Copy link
Collaborator

s-n-g commented Jan 5, 2025

That is very nice!

I have modified it a bit, added a bit of darker background for the secondary windows.
What do you think?
Can I keep this modification?

This is obviously a mockup...
mockup

Also, regardless of the change above, can we rename it to lambda_by_amski1?
I would like to have ascii only in items bundled withing the package

@amski1
Copy link
Author

amski1 commented Jan 5, 2025

Yes, absolutely. Cool gif, by the way.

How do I get the timer like you have here?

@s-n-g
Copy link
Collaborator

s-n-g commented Jan 5, 2025

This is still under development, you will get it when the next release is out 😉

@amski1
Copy link
Author

amski1 commented Jan 6, 2025

Wonderful. Props to whoever came up with it.

@s-n-g
Copy link
Collaborator

s-n-g commented Jan 6, 2025

#268

@amski1
Copy link
Author

amski1 commented Jan 6, 2025

😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants