Skip to content

Commit c022300

Browse files
authored
refactor: parse activityCode only when needed in getNormalAssignments filter
Agent-Logs-Url: https://github.com/coder13/Competitor-groups/sessions/cebd1b6a-e202-4765-907c-77cadcf9012c
1 parent bca8876 commit c022300

1 file changed

Lines changed: 5 additions & 8 deletions

File tree

src/containers/PersonalSchedule/utils.ts

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,20 +18,17 @@ export const getNormalAssignments = (wcif: Competition, person: Person) => {
1818
activity: allActivities.find(({ id }) => id === assignment.activityId),
1919
}))
2020
.filter((assignment) => {
21-
const activityCode = assignment.activity?.activityCode || '';
22-
const parsed = parseActivityCodeFlexible(activityCode);
2321
if (
2422
assignment.activity?.activityCode === 'other-multi' &&
2523
assignment.assignmentCode === 'competitor'
2624
) {
2725
return false;
2826
}
29-
if (
30-
parsed.eventId === '333fm' &&
31-
parsed.attemptNumber !== null &&
32-
assignment.assignmentCode === 'competitor'
33-
) {
34-
return false;
27+
if (assignment.assignmentCode === 'competitor') {
28+
const parsed = parseActivityCodeFlexible(assignment.activity?.activityCode || '');
29+
if (parsed.eventId === '333fm' && parsed.attemptNumber !== null) {
30+
return false;
31+
}
3532
}
3633
return true;
3734
})

0 commit comments

Comments
 (0)