Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer-To-Peer-Code-Review #9

Open
Amrhub opened this issue Sep 28, 2021 · 1 comment
Open

Peer-To-Peer-Code-Review #9

Amrhub opened this issue Sep 28, 2021 · 1 comment

Comments

@Amrhub
Copy link

Amrhub commented Sep 28, 2021

Peer to peer code review on Sep. 28, 2021 (Day 2 Week 3)
Before we start giving our opinions on @code-panther work we want to just address how awesome and what great of a job that piece of art is 🤩 Here we are aiming to increase awesomeness into the @code-panther


  1. I think it would be better if icons on the main page and footer were wrapped into <a> tag for functionality later on, what do you think?
  2. I think font size on mobile screens needs to be smaller for better user experience
  3. It would be nice if you delete the branches that are already merged, what do you think?
@AlexRS90
Copy link

Hello @code-panther, awesome work, there is a lot effort behind it, congratulations! It would be nice if you delete the branches that are already merged, what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants