Release v4.3.4

Author: actions-user

app/Config/App.php

@@ -105,6 +105,8 @@ class App extends BaseConfig
      *
      * The default timezone that will be used in your application to display
      * dates with the date helper, and can be retrieved through app_timezone()
+     *
+     * @see https://www.php.net/manual/en/timezones.php for list of timezones supported by PHP.
      */
     public string $appTimezone = 'UTC';
 

app/Config/Generators.php

@@ -26,6 +26,7 @@ class Generators extends BaseConfig
      * @var array<string, string>
      */
     public array $views = [
+        'make:cell'         => 'CodeIgniter\Commands\Generators\Views\cell.tpl.php',
         'make:command'      => 'CodeIgniter\Commands\Generators\Views\command.tpl.php',
         'make:config'       => 'CodeIgniter\Commands\Generators\Views\config.tpl.php',
         'make:controller'   => 'CodeIgniter\Commands\Generators\Views\controller.tpl.php',

public/index.php

@@ -47,7 +47,7 @@
  * ---------------------------------------------------------------
  *
  * The CodeIgniter class contains the core functionality to make
- * the application run, and does all of the dirty work to get
+ * the application run, and does all the dirty work to get
  * the pieces all working together.
  */
 
@@ -60,7 +60,7 @@
  *---------------------------------------------------------------
  * LAUNCH THE APPLICATION
  *---------------------------------------------------------------
- * Now that everything is setup, it's time to actually fire
+ * Now that everything is set up, it's time to actually fire
  * up the engines and make this app do its thang.
  */
 

system/API/ResponseTrait.php

@@ -13,6 +13,7 @@
 
 use CodeIgniter\Format\FormatterInterface;
 use CodeIgniter\HTTP\IncomingRequest;
+use CodeIgniter\HTTP\RequestInterface;
 use CodeIgniter\HTTP\ResponseInterface;
 use Config\Services;
 
@@ -21,7 +22,7 @@
  * consistent HTTP responses under a variety of common
  * situations when working as an API.
  *
- * @property IncomingRequest   $request
+ * @property RequestInterface  $request
  * @property ResponseInterface $response
  */
 trait ResponseTrait

system/BaseModel.php

@@ -63,8 +63,8 @@ abstract class BaseModel
      * The Database connection group that
      * should be instantiated.
      *
-     * @var string
-     * @phpstan-var non-empty-string
+     * @var string|null
+     * @phpstan-var non-empty-string|null
      */
     protected $DBGroup;
 

system/CLI/BaseCommand.php

@@ -105,7 +105,7 @@ abstract public function run(array $params);
     /**
      * Can be used by a command to run other commands.
      *
-     * @return mixed
+     * @return int|void
      *
      * @throws ReflectionException
      */
@@ -205,7 +205,7 @@ public function getPad(array $array, int $pad): int
     /**
      * Makes it simple to access our protected properties.
      *
-     * @return mixed
+     * @return array|Commands|LoggerInterface|string|null
      */
     public function __get(string $key)
     {

system/CLI/CLI.php

@@ -915,7 +915,7 @@ public static function getURI(): string
      *
      * **IMPORTANT:** The index here is one-based instead of zero-based.
      *
-     * @return mixed
+     * @return string|null
      */
     public static function getSegment(int $index)
     {

system/CodeIgniter.php

@@ -47,7 +47,7 @@ class CodeIgniter
     /**
      * The current version of CodeIgniter Framework
      */
-    public const CI_VERSION = '4.3.3';
+    public const CI_VERSION = '4.3.4';
 
     /**
      * App startup time.

system/Commands/Generators/CellGenerator.php

@@ -88,11 +88,8 @@ public function run(array $params)
         // Form the view name
         $segments = explode('\\', $this->qualifyClassName());
 
-        $view = array_pop($segments);
-        $view = str_replace('Cell', '', decamelize($view));
-        if (strpos($view, '_cell') === false) {
-            $view .= '_cell';
-        }
+        $view       = array_pop($segments);
+        $view       = decamelize($view);
         $segments[] = $view;
         $view       = implode('\\', $segments);
 

system/Commands/Generators/Views/model.tpl.php

@@ -10,7 +10,6 @@ class {class} extends Model
     protected $table            = '{table}';
     protected $primaryKey       = 'id';
     protected $useAutoIncrement = true;
-    protected $insertID         = 0;
     protected $returnType       = {return};
     protected $useSoftDeletes   = false;
     protected $protectFields    = true;

system/Commands/Utilities/Routes/AutoRouterImproved/ControllerMethodReader.php

@@ -65,8 +65,9 @@ public function read(string $class, string $defaultController = 'Home', string $
                     // Remove HTTP verb prefix.
                     $methodInUri = lcfirst(substr($methodName, strlen($httpVerb)));
 
+                    // Check if it is the default method.
                     if ($methodInUri === $defaultMethod) {
-                        $routeWithoutController = $this->getRouteWithoutController(
+                        $routeForDefaultController = $this->getRouteForDefaultController(
                             $classShortname,
                             $defaultController,
                             $classInUri,
@@ -75,8 +76,11 @@ public function read(string $class, string $defaultController = 'Home', string $
                             $httpVerb
                         );
 
-                        if ($routeWithoutController !== []) {
-                            $output = [...$output, ...$routeWithoutController];
+                        if ($routeForDefaultController !== []) {
+                            // The controller is the default controller. It only
+                            // has a route for the default method. Other methods
+                            // will not be routed even if they exist.
+                            $output = [...$output, ...$routeForDefaultController];
 
                             continue;
                         }
@@ -113,6 +117,12 @@ public function read(string $class, string $defaultController = 'Home', string $
                         $params[$param->getName()] = $required;
                     }
 
+                    // If it is the default controller, the method will not be
+                    // routed.
+                    if ($classShortname === $defaultController) {
+                        $route = 'x ' . $route;
+                    }
+
                     $output[] = [
                         'method'       => $httpVerb,
                         'route'        => $route,
@@ -151,9 +161,11 @@ private function getUriByClass(string $classname): string
     }
 
     /**
-     * Gets a route without default controller.
+     * Gets a route for the default controller.
+     *
+     * @phpstan-return list<array>
      */
-    private function getRouteWithoutController(
+    private function getRouteForDefaultController(
         string $classShortname,
         string $defaultController,
         string $uriByClass,

system/Config/BaseService.php

@@ -173,9 +173,9 @@ class BaseService
      *
      * $key must be a name matching a service.
      *
-     * @param mixed ...$params
+     * @param array|bool|float|int|object|string|null ...$params
      *
-     * @return mixed
+     * @return object
      */
     protected static function getSharedInstance(string $key, ...$params)
     {
@@ -239,7 +239,7 @@ public static function locator(bool $getShared = true)
      * Provides the ability to perform case-insensitive calling of service
      * names.
      *
-     * @return mixed
+     * @return object|null
      */
     public static function __callStatic(string $name, array $arguments)
     {
@@ -296,7 +296,7 @@ public static function resetSingle(string $name)
     /**
      * Inject mock object for testing.
      *
-     * @param mixed $mock
+     * @param object $mock
      */
     public static function injectMock(string $name, $mock)
     {
@@ -309,7 +309,7 @@ public static function injectMock(string $name, $mock)
      * looks for the service method in each, returning an instance of
      * the service, if available.
      *
-     * @return mixed
+     * @return object|null
      *
      * @deprecated
      *

system/Config/Config.php

@@ -23,7 +23,7 @@ class Config
      * @param string $name      Configuration name
      * @param bool   $getShared Use shared instance
      *
-     * @return mixed|null
+     * @return object|null
      */
     public static function get(string $name, bool $getShared = true)
     {

system/Cookie/Cookie.php

@@ -96,7 +96,7 @@ class Cookie implements ArrayAccess, CloneableCookieInterface
      * Default attributes for a Cookie object. The keys here are the
      * lowercase attribute names. Do not camelCase!
      *
-     * @var array<string, mixed>
+     * @var array<string, bool|int|string>
      */
     private static array $defaults = [
         'prefix'   => '',
@@ -124,7 +124,7 @@ class Cookie implements ArrayAccess, CloneableCookieInterface
      *
      * This method is called from Response::__construct().
      *
-     * @param array<string, mixed>|CookieConfig $config
+     * @param array<string, bool|int|string>|CookieConfig $config
      *
      * @return array<string, mixed> The old defaults array. Useful for resetting.
      */
@@ -195,9 +195,9 @@ public static function fromHeaderString(string $cookie, bool $raw = false)
     /**
      * Construct a new Cookie instance.
      *
-     * @param string               $name    The cookie's name
-     * @param string               $value   The cookie's value
-     * @param array<string, mixed> $options The cookie's options
+     * @param string                         $name    The cookie's name
+     * @param string                         $value   The cookie's value
+     * @param array<string, bool|int|string> $options The cookie's options
      *
      * @throws CookieException
      */
@@ -595,8 +595,8 @@ public function offsetGet($offset)
     /**
      * Offset to set.
      *
-     * @param string $offset
-     * @param mixed  $value
+     * @param string          $offset
+     * @param bool|int|string $value
      *
      * @throws LogicException
      */

system/Cookie/CookieInterface.php

@@ -143,7 +143,7 @@ public function isRaw(): bool;
      * Gets the options that are passable to the `setcookie` variant
      * available on PHP 7.3+
      *
-     * @return array<string, mixed>
+     * @return array<string, bool|int|string>
      */
     public function getOptions(): array;
 
@@ -162,7 +162,7 @@ public function __toString();
     /**
      * Returns the array representation of the Cookie object.
      *
-     * @return array<string, mixed>
+     * @return array<string, bool|int|string>
      */
     public function toArray(): array;
 }

system/Database/BaseConnection.php

@@ -456,7 +456,8 @@ abstract protected function _close();
     /**
      * Create a persistent database connection.
      *
-     * @return mixed
+     * @return false|object|resource
+     * @phpstan-return false|TConnection
      */
     public function persistentConnect()
     {
@@ -558,7 +559,7 @@ abstract protected function execute(string $sql);
      * Should automatically handle different connections for read/write
      * queries if needed.
      *
-     * @param mixed ...$binds
+     * @param array|string|null $binds
      *
      * @return BaseResult|bool|Query BaseResult when “read” type query, bool when “write” type query, Query when prepared query
      * @phpstan-return BaseResult<TConnection, TResult>|bool|Query
@@ -1747,7 +1748,7 @@ protected function _enableForeignKeyChecks()
     /**
      * Accessor for properties if they exist.
      *
-     * @return mixed
+     * @return array|bool|float|int|object|resource|string|null
      */
     public function __get(string $key)
     {