feature(savepoints): dont disable savepoints for OCI8/SQLSRV as they are implemented now

mkuettel · mkuettel · commit 1254e83f9615 · 2024-05-16T21:19:16.000+02:00
diff --git a/system/Database/OCI8/Connection.php b/system/Database/OCI8/Connection.php
@@ -121,8 +121,6 @@ public function initialize()
     {
         $result = parent::initialize(); // TODO: Change the autogenerated stub
 
-        $this->enableSavepoints = false; // not supported
-
         return $result;
     }
 
diff --git a/system/Database/SQLSRV/Connection.php b/system/Database/SQLSRV/Connection.php
@@ -98,8 +98,6 @@ public function __construct(array $params)
         if ($this->scrollable === null) {
             $this->scrollable = defined('SQLSRV_CURSOR_CLIENT_BUFFERED') ? SQLSRV_CURSOR_CLIENT_BUFFERED : false;
         }
-
-        $this->enableSavepoints = false; // not implemented so disable it
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -121,8 +121,6 @@ public function initialize()`
`121`	`121`	`{`
`122`	`122`	`$result = parent::initialize(); // TODO: Change the autogenerated stub`
`123`	`123`
`124`		`- $this->enableSavepoints = false; // not supported`
`125`		`-`
`126`	`124`	`return $result;`
`127`	`125`	`}`
`128`	`126`
Original file line number	Diff line number	Diff line change
`@@ -98,8 +98,6 @@ public function __construct(array $params)`
`98`	`98`	`if ($this->scrollable === null) {`
`99`	`99`	`$this->scrollable = defined('SQLSRV_CURSOR_CLIENT_BUFFERED') ? SQLSRV_CURSOR_CLIENT_BUFFERED : false;`
`100`	`100`	`}`
`101`		`-`
`102`		`- $this->enableSavepoints = false; // not implemented so disable it`
`103`	`101`	`}`
`104`	`102`
`105`	`103`	`/**`