Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the elements of the footer are now redirecting to the respective page for … #409

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Sarthak-06
Copy link

@Sarthak-06 Sarthak-06 commented Sep 16, 2021

…ex if we click instagram icon it will open a instagram page in a new tab

#406

fixes #

Describe the changes you've made
I have added links to all social media icons like instagram, twitter, youtube and github. I have used react-icons. For that i installed it by adding command npm install react-icons --save then i wrapped the code within IconButton. I have deleted the code that used map and icon list to display those social media icons.

Describe if there is any unusual behavior (Any Warning) of your code(Write NA if there isn't)
I also got some warning like
Line 55:28: Replace ·href="https://twitter.com/codeforcauseIn?ref_src=twsrc%5Egoogle%7Ctwcamp%5Eserp%7Ctwgr%5Eauthor"·target="_blank"·aria-label="Twitter" with ␍⏎··················href="https://twitter.com/codeforcauseIn?ref_src=twsrc%5Egoogle%7Ctwcamp%5Eserp%7Ctwgr%5Eauthor"␍⏎··················target="_blank"␍⏎··················aria-label="Twitter"␍⏎················

Additional context (OPTIONAL)

Test plan (OPTIONAL)

A good test plan should give instructions that someone else can easily follow.

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • The title of my pull request is a short description of the requested changes.

Provide a Deployed link of route/page that needs to review
Preview: Deploy preview link here with the appropriate route

…ex if we click instagram icon it will open a instagram page in a new tab
…ex if we click instagram icon it will open a instagram page in a new tab
@Abhishek-kumar09
Copy link
Contributor

@Sarthak-06 Please provide a screenshot of the footer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants