Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create github action for running lint on code and show errors #81

Open
Abhishek-kumar09 opened this issue Jun 9, 2021 · 4 comments · May be fixed by #90
Open

Create github action for running lint on code and show errors #81

Abhishek-kumar09 opened this issue Jun 9, 2021 · 4 comments · May be fixed by #90

Comments

@Abhishek-kumar09
Copy link
Contributor

We are formatting the code with prettier, need that to run on github actions so that the outputs can be seen on the PRs on gthub.

@zeborg
Copy link
Contributor

zeborg commented Jun 11, 2021

Are we planning on an automated modification of the committed code itself by prettifying it through an actions bot, or just a console output in actions log as we currently see for the syntax errors?

@Abhishek-kumar09
Copy link
Contributor Author

Anything works fine.

@piall
Copy link
Contributor

piall commented Jun 13, 2021

@zeborg Are you working on this?. If you are not I would like to work on this.

@zeborg
Copy link
Contributor

zeborg commented Jun 14, 2021

@zeborg Are you working on this?. If you are not I would like to work on this.

@mdpial Hey bro! Yup, I've been testing it on my fork till now and it finally seems to be ok from my end. Will be making a PR soon.

@zeborg zeborg linked a pull request Jun 14, 2021 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants