Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Produce helpful error message on upload timeout failure #65

Open
alanjosephwilliams opened this issue Jul 12, 2014 · 7 comments
Open

Produce helpful error message on upload timeout failure #65

alanjosephwilliams opened this issue Jul 12, 2014 · 7 comments
Assignees
Labels

Comments

@alanjosephwilliams
Copy link
Contributor

On the production open-trails.herokuapp.com (but not locally), the Validator crashes when the the full set of OpenTrails data describing the Ohio system (which is 1.6 MB, with all five files included) is uploaded.

screenshot 2014-07-12 15 11 15

@alanjosephwilliams alanjosephwilliams changed the title Error logging: production validator fails on upload production validator fails on upload Jul 12, 2014
@migurski
Copy link
Contributor

I wasn't able to replicate this bug on the live site or my local copy.

@alanjosephwilliams
Copy link
Contributor Author

Based on the Heroku logs, and my ability to reproduce only on public connections (like hotel lobbies), it appears to be a timeout issue:

2014-07-13T14:44:58.251582+00:00 app[web.1]: 2014-07-13 14:44:58 [2] [CRITICAL] WORKER TIMEOUT (pid:25)
2014-07-13T14:44:58.264830+00:00 app[web.1]: 2014-07-13 14:44:58 [42] [INFO] Booting worker with pid: 42
2014-07-13T14:44:58.259190+00:00 app[web.1]: 2014-07-13 14:44:58 [2] [CRITICAL] WORKER TIMEOUT (pid:25)

We should make this failure more graceful. @ondrae what was your suggestion from earlier going to be?

@alanjosephwilliams alanjosephwilliams changed the title production validator fails on upload Improve UX of timeout failure on upload Jul 14, 2014
@alanjosephwilliams alanjosephwilliams changed the title Improve UX of timeout failure on upload Produce helpful error message on upload timeout failure Jul 14, 2014
@ondrae
Copy link
Collaborator

ondrae commented Jul 14, 2014

You can upload direct to S3 from the client instead of to Heroku first. There might some way to put it into a separate process too.

You can notify the user when the file is uploaded, or just show it on screen when its finished.

@migurski
Copy link
Contributor

Direct to S3 is probably the way to go here. The feature is called something like Signed POST, and triggers a callback. A smart thing to use, and cuts down on one complete round trip.

@migurski
Copy link
Contributor

I’ve implemented this before in PHP, can help as needed.

@alanjosephwilliams
Copy link
Contributor Author

This seems like an improvement that may be warranted in advance of UC—I can
imagine audience members attempting to upload data right there during or
after the talk, and hitting the timeout on wifi saddled with untold numbers
of conference goers.

Take this one as you see fit @migurski.

On Mon, Jul 14, 2014 at 6:50 PM, migurski [email protected] wrote:

I’ve implemented this before in PHP
https://github.com/migurski/paperwalking/blob/master/site/lib/data.php#L1191,
can help as needed.


Reply to this email directly or view it on GitHub
#65 (comment).

t: @alanjosephwilli
p: 817 713 6264

@migurski
Copy link
Contributor

Good point, I will attempt to implement this.

@migurski migurski self-assigned this Jul 14, 2014
@migurski migurski added this to the Esri UC Presentation milestone Jul 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants