Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in "walk the trail" finding parent file by uuid #6

Closed
Ma3xl3 opened this issue Nov 7, 2014 · 1 comment
Closed

Bug in "walk the trail" finding parent file by uuid #6

Ma3xl3 opened this issue Nov 7, 2014 · 1 comment

Comments

@Ma3xl3
Copy link

Ma3xl3 commented Nov 7, 2014

First thx for the great plugin :)

I've wondered why my social image on the root page didn't append to the page. The bug is in file SocialImages.php on line 57

if ($objTrail->socialImage && ($objImage = \FilesModel::findByUuid($objPage->socialImage)) !== null && is_file(TL_ROOT . '/' . $objImage->path))

instead of $objPage in the findByUuid method this should be $objTrail

if ($objTrail->socialImage && ($objImage = \FilesModel::findByUuid($objTrail->socialImage)) !== null && is_file(TL_ROOT . '/' . $objImage->path))
@Ma3xl3 Ma3xl3 changed the title Bug in "walk the trail" finding parent the file by uuid Bug in "walk the trail" finding parent file by uuid Nov 7, 2014
qzminski added a commit that referenced this issue Nov 7, 2014
@qzminski
Fixed the bug with image not being inherited from page trail (see #6)
ba91f23
@qzminski
Copy link
Member

qzminski commented Nov 7, 2014

Fixed in ba91f23.

@qzminski qzminski closed this as completed Nov 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@qzminski @Ma3xl3