image URL is double encoded

[fritzmg]

If the path to the social image is

files/content/FALTER_Scheckübergabe 2018 (c) Karin Wasner.jpeg

for example, the resulting og:image URL will be

https://example.org/files/content/FALTER_Scheck%25C3%25BCbergabe%25202018%2520%2528c%2529%2520Karin%2520Wasner.jpeg

i.e. the URL is double encoded. The correct URL would be

https://example.org/files/content/FALTER_Scheck%C3%BCbergabe%202018%20%28c%29%20Karin%20Wasner.jpeg

Tested in Contao 4.4.13 with Social Images 3.5.2.

[qzminski]

Hm I have set up the filename as you suggested but it seems to work fine for me:

<meta property="og:image" content="http://tmp:8888/files/test/FALTER_Scheck%C3%BCbergabe%202018%20%28c%29%20Karin%20Wasner.jpg">

Can you find out which module includes this image (core, news, etc.) ?

[fritzmg]

It's from a news list (image of the first news in the list on that page).

[qzminski]

I am still unable to reproduce that on MacOS 🙈 can you find out the fix for yourself?

Is the image size calculated correctly? If it's double encoded then it should not work either...

[fritzmg]

Yeah, I'll debug :)

[fritzmg]

Ah, you need to set an image size in the page layout for the social images. \Image::get already encodes the image path. That's why it gets double encoded (even when it's not actually resized of course).

[fritzmg]

I'd propose the following:

    // Resize the image
    if ($resize[0] || $resize[1] || $resize[2]) {
-       $strImage = \Image::get($strImage, $resize[0], $resize[1], $resize[2]);
+       $strImage = urldecode(\Image::get($strImage, $resize[0], $resize[1], $resize[2]));
-       list($width, $height) = getimagesize(TL_ROOT . '/' . urldecode($strImage));
+       list($width, $height) = getimagesize(TL_ROOT . '/' . $strImage);
    }

[qzminski]

I was about to write exactly the same. Thanks, I will fix this soon!

[qzminski]

3.5.3 is released now.