Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maximum image size setting #20

Closed
fritzmg opened this issue Jan 9, 2018 · 7 comments
Closed

maximum image size setting #20

fritzmg opened this issue Jan 9, 2018 · 7 comments

Comments

@fritzmg
Copy link
Contributor

fritzmg commented Jan 9, 2018

If you allow pretty large images in your Contao installation and an editor happens to use a large image (eg. 5568x3712), Facebook for example might not use the image:

Provided og:image URL, https://example.org/files/content/foo.jpg could not be downloaded because it exceeded the maximum allowed sized of 8Mb.

To counter act such instances it would make sense to provide an image size setting or simply a maximum size setting (in addition to the minimum size setting) in the page layout, so that the image can be downscaled automatically.

@qzminski
Copy link
Member

Would you downscale the image or just ignore it (like for minimum size setting)?

Also, the Facebook error you get refers explicitly to the file size and not the image dimensions... although they are related they should not be considered the same.

@fritzmg
Copy link
Contributor Author

fritzmg commented Jan 10, 2018

Would you downscale the image or just ignore it (like for minimum size setting)?

I would downscale it. This way one can also choose that each share image has the same format for example (cut or even zoomed to the important part).

@qzminski
Copy link
Member

Erm... but that downscaling & cropping would happen only if the image has too big dimensions? Or would you then apply it to all images? 🤔

@fritzmg
Copy link
Contributor Author

fritzmg commented Jan 11, 2018

In Contao 4 images will not be upscaled, so it would only apply to images that have bigger dimensions by default.

In Contao 3 images would be upscaled.

@qzminski
Copy link
Member

Can you check if 0b3591b fulfill your needs?

@fritzmg
Copy link
Contributor Author

fritzmg commented Jan 17, 2018

Yes 👍 :)

@qzminski
Copy link
Member

Perfect, just released 3.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants