Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework the extension #1

Closed
qzminski opened this issue Jun 26, 2014 · 1 comment
Closed

Rework the extension #1

qzminski opened this issue Jun 26, 2014 · 1 comment
Assignees
@qzminski
Labels
enhancement
Milestone
3.0.0

Comments

@qzminski
Copy link
Member

The extension should not override Image class to collect the images. It should rather use hooks:

  • getContentElement (ce)
  • parseArticles (news)
  • getAllEvents (events)
@qzminski qzminski added this to the 2.0.0 milestone Jun 26, 2014
@qzminski qzminski self-assigned this Jun 26, 2014
qzminski added a commit that referenced this issue Jun 26, 2014
@qzminski
Reworked the image gathering mechanism (see #1)
dad524b
@qzminski
Copy link
Member Author

Completed in dad524b.

qzminski added a commit that referenced this issue Jun 29, 2014
@qzminski
Revert "Reworked the image gathering mechanism (see #1)"
326ecfc 
This reverts commit dad524b.
qzminski added a commit that referenced this issue Jun 29, 2014
@qzminski
Reworked the image gathering mechanism (see #1)
c936f4c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qzminski qzminski

Labels
enhancement
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
1 participant
@qzminski