Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Heroku CI not supported #21

Closed
marvin-bitterlich opened this issue Apr 17, 2017 · 10 comments
Closed

Heroku CI not supported #21

marvin-bitterlich opened this issue Apr 17, 2017 · 10 comments

Comments

@marvin-bitterlich
Copy link

Heroku CI is in Beta right now. Sadly it does not test inside a git repo, so you have to parse their env variables: https://devcenter.heroku.com/articles/heroku-ci#environment-variables

Any possibilty to add support?

@stevepeak
Copy link
Contributor

Hey @Kostronor Thank you for the issue 👍

Do you know if $ git is available during the CI build? That can pull the correct commit information.

I'll add support to detect Heroku, but it appears there are only 2 default environment variables which does not really help.

@marvin-bitterlich
Copy link
Author

It seems they do not have git on their CI system. But their system is in beta, so maybe you can still convince them to support it or give better ENV 😉

@stevepeak
Copy link
Contributor

Ok. Hopefully they will add more environment variables and git support. Otherwise, it may be difficult to get the context of the upload.

@marvin-bitterlich
Copy link
Author

Feedback

We’re eager to hear about your experience (and help) with Heroku CI, so please send comments and questions to [email protected] .

I've send them a feedback mail with a link to this issue.

@appleton
Copy link

👋 Hello, I'm on the Heroku CI team. This is definitely something we'd like to support, we've had a similar request for codeclimate so I'd like to try and get a full set of information which anyone can make use of.

We can't easily give you git and a repository but we can most likely give you some environment variables with the information you need. Could you let me know what you'd need?

@stujo
Copy link

stujo commented May 19, 2017

@stevepeak Sounds like Heroku CI is on board to help if we can give them the info they need, would love to get this working. Please let me know how I can help

@stevepeak
Copy link
Contributor

@appleton my apologies on the delay. We should schedule a chat to discuss this integration process. Are there been any changes that I should be aware of? Thanks!

@appleton
Copy link

Hi @stevepeak I don't work at Herkou any more, I think you'd be best chatting with @joshwlewis or @raulb

@meganemura
Copy link
Contributor

We can close this issue since #28 is merged.

@nfm
Copy link
Contributor

nfm commented Nov 22, 2019

Please close this issue, it has been resolved.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants