-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Token required - not valid tokenless upload
when token is provided
#1671
Comments
@Cardds I pushed out |
This comment has been minimized.
This comment has been minimized.
@thomasrockhu-codecov No dice, but different error (see below for log output). May need quotes around
|
Mmm spoke to soon, PRs still not passing the CI run with 5.0.3. Action run in debug
|
@Cardds I believe you might have a newline character at the end of your CODECOV_TOKEN, can you double-check that? |
@MarcHagen are you able to link that CI run by chance? |
No sorry, private repo in (non-public) organization. |
@MarcHagen ahhh, tokens are required for all PRs into private repositories. |
I know that is why the token is provided with in the action (also for PRs). And it worked perfectly fine until 5.x OR are you referring to the input |
@MarcHagen got it! ok, let me check with the product team |
Retested with a newly added secret with the codecov token, and that job proceeded without issue, so that analysis seems spot-on. 👍 I will note that this existing token value that broke with v5 was confirmed to work with both v3 and v4 of the codecov-action. Perhaps this should be called out as a breaking change in the action? |
@Cardds |
@MarcHagen can you try the latest and see if it's working for you? @Cardds fyi the fix that strips out the newline is in the Action now |
@thomasrockhu-codecov 5.0.6 seems to indeed fix that. No 'fork detected' and uploaded fine. Commit and PR 👍🏻. |
@MarcHagen phew! ok, closing thie one out |
Upon upgrade to
codecov/codecov-action@v5
fromcodecov/codecov-action@v4
, the action begins to fail, citingToken required - not valid tokenless upload
.This appears to occur as a result of the branch that results in message
Fork detected, tokenless uploading used
.Relevant workflow snippet:
GH action logs:
This issue also appears to be described in #1645 (comment)
The text was updated successfully, but these errors were encountered: