Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5 Error: Got unexpected extra argument #1659

Closed
MetRonnie opened this issue Nov 15, 2024 · 11 comments
Closed

v5 Error: Got unexpected extra argument #1659

MetRonnie opened this issue Nov 15, 2024 · 11 comments
Assignees
Labels
Area: Report Upload Issues with pre-ingest report uploading Medium Medium Priority Issues (to be fixed or re-evaluated in 3 months

Comments

@MetRonnie
Copy link

MetRonnie commented Nov 15, 2024

v5 of the action does not appear to quote the workflow name when calling ./codecov do-upload so fails if there are spaces in the workflow name: https://github.com/cylc/cylc-flow/actions/runs/11853961703/job/33053084597?pr=6479#step:4:182

@MetRonnie MetRonnie changed the title Error: Got unexpected extra argument v5 Error: Got unexpected extra argument Nov 15, 2024
@MetRonnie
Copy link
Author

Tagging @codecov/report-upload as mentioned in #1645

@thomasrockhu-codecov
Copy link
Contributor

On it @MetRonnie, thanks for the catch

@thomasrockhu-codecov thomasrockhu-codecov self-assigned this Nov 15, 2024
@thomasrockhu-codecov thomasrockhu-codecov added bug Something isn't working Medium Medium Priority Issues (to be fixed or re-evaluated in 3 months Area: Report Upload Issues with pre-ingest report uploading and removed bug Something isn't working labels Nov 15, 2024
@hugovk
Copy link

hugovk commented Nov 15, 2024

Similarly: https://github.com/hugovk/pepotron/actions/runs/11860034700/job/33054377932?pr=65#step:8:230

Error: Got unexpected extra arguments (Python 3.10)

Called like:

      - name: Upload coverage
        uses: codecov/codecov-action@v5
        with:
          flags: ${{ matrix.os }}
          name: ${{ matrix.os }} Python ${{ matrix.python-version }}

@njzjz
Copy link

njzjz commented Nov 15, 2024

For me, I got this error with my OIDC token (which is hidden by the GitHub):

 -> Token of length 1909 detected
==> Running create-commit
      ./codecov  create-commit -t <redacted> --git-service github --sha 7e5912295d0e5036241178cbc769db454d2df1b0
info - 2024-11-15 19:22:45,290 -- ci service found: github-actions
warning - 2024-11-15 19:22:45,299 -- No config file could be found. Ignoring config.
Usage: codecov create-commit [OPTIONS]
Try 'codecov create-commit -h' for help.

Error: Got unexpected extra argument (value:***
==> Failed to create-commit

@iliapolo
Copy link

We are seeing the same behavior as #1659 (comment). The workflow name does not contain spaces.

See https://github.com/cdklabs/cdk-from-cfn/actions/runs/11908452810/job/33184203992?pr=747

@thomasrockhu-codecov
Copy link
Contributor

thomasrockhu-codecov commented Nov 19, 2024

@njzjz @iliapolo 5.0.3 has a fix for the OIDC issue

@thomasrockhu-codecov
Copy link
Contributor

@MetRonnie @hugovk still working on this issue

@thomasrockhu-codecov
Copy link
Contributor

@MetRonnie @hugovk would you be able to try the latest v5 5.0.4?

@hugovk
Copy link

hugovk commented Nov 20, 2024

Thanks, I no longer get the error: https://github.com/hugovk/pepotron/actions/runs/11860034700/job/33247555679?pr=65

info - 2024-11-20 08:08:40,088 -- Your upload is now processing. When finished, results will be available at: https://app.codecov.io/github/hugovk/pepotron/commit/7ef0abf15fcb8600f034f21ba8cbe3a07b452baf
info - 2024-11-20 08:08:40,422 -- Process Upload complete

@MetRonnie
Copy link
Author

Working for us now 👍

@thomasrockhu-codecov
Copy link
Contributor

Awesome, going to close out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Report Upload Issues with pre-ingest report uploading Medium Medium Priority Issues (to be fixed or re-evaluated in 3 months
Projects
None yet
Development

No branches or pull requests

5 participants