Add Product Quantities doubled in Backend Order Creation

[nige-one]

Backend

• Magento version: 2.4.6-p3
• Module version: 1.3.2

Settings / Sale Rules

1. Have a example rule that will trigger

Steps to reproduce

1. Create a backend order
2. Add a product
3. Qty will be doubled if freeproduct rule will be triggered (causing "not available" for stock = 1 products)

Expected result

1. My added product will be added with the configured amount

Actual result

1. Added products have double qty in backend order

This only applies for backend orders. The issue comes from commit e7d3e96. If quote items are set "again" from the quotes items collection, the following quote repo save operation will trigger a second addProduct on the quote for the items set resulting in an update on the item's qty with the qty of the initial request.

After commenting out the lines in the mentioned commit, everything seems to work fine again. Maybe this is some 2.4.6-p3 thing, I didn't test intensivly.

[nige-one]

Unfortunately commenting out the mentioned commit leads back to the former issue of multiple freeproducts added.

[nige-one]

I just added a sluggish patch. Since it only triggers in the BE I share it:

--- a/Observer/ResetGiftItems.php
+++ b/Observer/ResetGiftItems.php
@@ -63,7 +63,11 @@
         // In admin the quote items are empty although items exist
         if ($this->isAdminContext) {
             if ((int)$quote->getItemsCount() > 0 && $quote->getItems() == null) {
-                $quote->setItems($quote->getItemsCollection()->getItems());
+                foreach ($quote->getItemsCollection()->getItems() as $item) {
+                    if ($item->getOptionByCode('freeproduct_gift_unique_id') instanceof Quote\Item\Option) {
+                        $quote->getItemsCollection()->removeItemByKey($item->getItemId());
+                    }
+                }
             }
         }

[iranimij]

I also have the same problem. Don't you have any plans for updating the module?

[iranimij]

@nige-one You patch does not seem ok, since in the previous version, they were setting the items, but you are just removing the items. I think it should be set anyway