diff --git a/packages/nc-gui/components/cell/SingleSelect/Readonly.vue b/packages/nc-gui/components/cell/SingleSelect/Readonly.vue index 9778b2ebf4eb..5661719bdde2 100644 --- a/packages/nc-gui/components/cell/SingleSelect/Readonly.vue +++ b/packages/nc-gui/components/cell/SingleSelect/Readonly.vue @@ -33,7 +33,7 @@ const optionsMap = computed(() => { }) const selectedOpt = computed(() => { - return modelValue ? optionsMap.value[modelValue?.trim()] : undefined + return typeof modelValue === 'string' ? optionsMap.value[modelValue.trim()] : undefined }) diff --git a/packages/nc-gui/components/smartsheet/Form.vue b/packages/nc-gui/components/smartsheet/Form.vue index f2af3456e5c1..b9ab12db9e1b 100644 --- a/packages/nc-gui/components/smartsheet/Form.vue +++ b/packages/nc-gui/components/smartsheet/Form.vue @@ -449,7 +449,7 @@ function onMoveCallback(event: any) { } async function onMove(event: any, isVisibleFormFields = false) { - if (isLocked.value || !isEditable) return + if (isLocked.value || !isEditable || !view.value) return let { newIndex, element } = event.moved @@ -766,7 +766,7 @@ async function onFieldMoveToNewRow(event: any, beforeRowKey?: string) { } async function showOrHideColumn(column: Record, show: boolean, isFormSettings = false) { - if (isLocked.value || !isEditable) return + if (isLocked.value || !isEditable || !view.value) return if (shouldSkipColumn(column)) { // Required field can't be moved diff --git a/packages/nc-gui/components/smartsheet/grid/canvas/cells/Lookup.ts b/packages/nc-gui/components/smartsheet/grid/canvas/cells/Lookup.ts index 660bd6fe0908..b901f1c576ac 100644 --- a/packages/nc-gui/components/smartsheet/grid/canvas/cells/Lookup.ts +++ b/packages/nc-gui/components/smartsheet/grid/canvas/cells/Lookup.ts @@ -65,7 +65,7 @@ export const LookupCellRenderer: CellRenderer = { const relatedModelId = relatedColOptions.fk_related_model_id if (!relatedModelId) return - if (tableMetaLoader.isLoading(relatedModelId, relatedBaseId)) return + if (!tableMetaLoader || tableMetaLoader.isLoading(relatedModelId, relatedBaseId)) return tableMetaLoader.getTableMeta(relatedModelId, relatedBaseId) @@ -164,7 +164,7 @@ export const LookupCellRenderer: CellRenderer = { // Restore canvas context before returning — ctx.save()/ctx.clip() was already called above ctx.restore() - if (tableMetaLoader.isLoading(lkRelatedModelId, lkRelatedBaseId)) return + if (!tableMetaLoader || tableMetaLoader.isLoading(lkRelatedModelId, lkRelatedBaseId)) return tableMetaLoader.getTableMeta(lkRelatedModelId, lkRelatedBaseId) diff --git a/packages/nc-gui/components/smartsheet/toolbar/FieldListAutoCompleteDropdown.vue b/packages/nc-gui/components/smartsheet/toolbar/FieldListAutoCompleteDropdown.vue index c617f6860f08..d24301665933 100644 --- a/packages/nc-gui/components/smartsheet/toolbar/FieldListAutoCompleteDropdown.vue +++ b/packages/nc-gui/components/smartsheet/toolbar/FieldListAutoCompleteDropdown.vue @@ -130,7 +130,7 @@ const options = computed(() => })), ) -const filterOption = (input: string, option: any) => option.label.toLowerCase()?.includes(input.toLowerCase()) +const filterOption = (input: string, option: any) => option.label?.toLowerCase()?.includes(input.toLowerCase()) // when a new filter is created, select a field by default if (!localValue.value && allowEmpty !== true) { diff --git a/packages/nc-gui/components/smartsheet/toolbar/ViewActionMenu.vue b/packages/nc-gui/components/smartsheet/toolbar/ViewActionMenu.vue index fc70c5a110e6..0a4cfe092645 100644 --- a/packages/nc-gui/components/smartsheet/toolbar/ViewActionMenu.vue +++ b/packages/nc-gui/components/smartsheet/toolbar/ViewActionMenu.vue @@ -822,7 +822,7 @@ defineOptions({ ) => v.enabled === true).length === 0) { + if ((srcDestMapping.value[tn] || []).filter((v: Record) => v.enabled === true).length === 0) { const err = t('msg.error.selectAtleastOneColumn') if (showError) { message.error(err) diff --git a/packages/nc-gui/components/virtual-cell/components/ItemChip.vue b/packages/nc-gui/components/virtual-cell/components/ItemChip.vue index 0b4ba921ba84..fcf0cf7fe508 100644 --- a/packages/nc-gui/components/virtual-cell/components/ItemChip.vue +++ b/packages/nc-gui/components/virtual-cell/components/ItemChip.vue @@ -153,6 +153,7 @@ export default {