Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): replace clui on @isaacs/cliui #282

Merged
merged 1 commit into from
Nov 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
164 changes: 163 additions & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@
},
"dependencies": {
"@code-pushup/portal-client": "^0.1.2",
"@isaacs/cliui": "^8.0.2",
"@swc/helpers": "~0.5.0",
"bundle-require": "^4.0.1",
"chalk": "^5.3.0",
"cli-table3": "^0.6.3",
"cliui": "^8.0.1",
"multi-progress-bars": "^5.0.3",
"simple-git": "^3.20.0",
"yargs": "^17.7.2",
Expand Down
2 changes: 1 addition & 1 deletion packages/utils/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"@code-pushup/models": "*",
"bundle-require": "^4.0.1",
"chalk": "^5.3.0",
"cliui": "^8.0.1",
"@isaacs/cliui": "^8.0.2",
"simple-git": "^3.20.0",
"multi-progress-bars": "^5.0.3",
"cli-table3": "^0.6.3"
Expand Down
28 changes: 14 additions & 14 deletions packages/utils/src/lib/__snapshots__/report-to-stdout.spec.ts.snap
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,14 @@ ESLint audits
● Disallow assignment operators in conditional expressions 0
● Disallow reassigning \`const\` variables 0
● Disallow the use of \`debugger\` 0
● Disallow invalid regular expression strings in \`RegExp\` construct 0
ors
● Disallow the use of undeclared variables unless mentioned in \`/*g 0
lobal */\` comments
● Disallow invalid regular expression strings in \`RegExp\` 0
constructors
● Disallow the use of undeclared variables unless mentioned in 0
\`/*global */\` comments
● Disallow loops with a body that allows only one iteration 0
● Disallow negating the left operand of relational operators 0
● Disallow use of optional chaining in contexts where the \`undefine 0
d\` value is not allowed
● Disallow use of optional chaining in contexts where the 0
\`undefined\` value is not allowed
● Disallow unused variables 1 warning
● Require calls to \`isNaN()\` when checking for \`NaN\` 0
● Enforce comparing \`typeof\` expressions against valid strings 0
Expand All @@ -29,20 +29,20 @@ ESLint audits
● Disallow variable declarations from shadowing variables declared 3 warnings
in the outer scope
● Require \`let\` or \`const\` instead of \`var\` 0
● Require or disallow method and property shorthand syntax for obje 3 warnings
ct literals
● Require or disallow method and property shorthand syntax for 3 warnings
object literals
● Require using arrow functions for callbacks 0
● Require \`const\` declarations for variables that are never reassig 1 warning
ned after declared
● Require \`const\` declarations for variables that are never 1 warning
reassigned after declared
● Disallow using Object.assign with an object literal as the first 0
argument and prefer the use of object spread instead
● Require or disallow \\"Yoda\\" conditions 0
● Disallow missing \`key\` props in iterators/collection literals 1 warning
● Disallow missing props validation in a React component definition 6 warnings
● Disallow missing React when using JSX 0
● enforces the Rules of Hooks 0
● verifies the list of dependencies for Hooks like useEffect and si 2 warnings
milar
● verifies the list of dependencies for Hooks like useEffect and 2 warnings
similar
● Disallow missing displayName in a React component definition 0
● Disallow comments from being inserted as text nodes 0
● Disallow duplicate properties in JSX 0
Expand All @@ -51,8 +51,8 @@ ESLint audits
● Disallow React to be incorrectly marked as unused 0
● Disallow variables used in JSX to be incorrectly marked as unused 0
● Disallow passing of children as props 0
● Disallow when a DOM element is using both children and dangerousl 0
ySetInnerHTML
● Disallow when a DOM element is using both children and 0
dangerouslySetInnerHTML
● Disallow usage of deprecated methods 0
● Disallow direct mutation of this.state 0
● Disallow usage of findDOMNode 0
Expand Down
2 changes: 1 addition & 1 deletion packages/utils/src/lib/report-to-stdout.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import cliui from '@isaacs/cliui';
import chalk from 'chalk';
import Table from 'cli-table3';
import cliui from 'cliui';
import { NEW_LINE } from './md';
import {
CODE_PUSHUP_DOMAIN,
Expand Down