refactor: wip

Author: BioPhoton

packages/cli/mocks/configs/code-pushup.config.js

@@ -0,0 +1,43 @@
+export default {
+  upload: {
+    organization: 'code-pushup',
+    project: 'cli-js',
+    apiKey: 'e2e-api-key',
+    server: 'https://e2e.com/api',
+  },
+  categories: [
+    {
+      slug: 'category-1',
+      title: 'Category 1',
+      refs: [
+        {
+          type: 'audit',
+          plugin: 'node',
+          slug: 'node-version',
+          weight: 1,
+        },
+      ],
+    },
+  ],
+  plugins: [
+    {
+      audits: [
+        {
+          slug: 'node-version',
+          title: 'Node version',
+          description: 'prints node version to file',
+          docsUrl: 'https://nodejs.org/',
+        },
+      ],
+      runner: {
+        command: 'node',
+        args: ['-v'],
+        outputFile: 'output.json',
+      },
+      groups: [],
+      slug: 'node',
+      title: 'Node.js',
+      icon: 'javascript',
+    },
+  ],
+};

packages/cli/mocks/configs/code-pushup.config.mjs

@@ -0,0 +1,43 @@
+export default {
+  upload: {
+    organization: 'code-pushup',
+    project: 'cli-mjs',
+    apiKey: 'e2e-api-key',
+    server: 'https://e2e.com/api',
+  },
+  categories: [
+    {
+      slug: 'category-1',
+      title: 'Category 1',
+      refs: [
+        {
+          type: 'audit',
+          plugin: 'node',
+          slug: 'node-version',
+          weight: 1,
+        },
+      ],
+    },
+  ],
+  plugins: [
+    {
+      audits: [
+        {
+          slug: 'node-version',
+          title: 'Node version',
+          description: 'prints node version to file',
+          docsUrl: 'https://nodejs.org/',
+        },
+      ],
+      runner: {
+        command: 'node',
+        args: ['-v'],
+        outputFile: 'output.json',
+      },
+      groups: [],
+      slug: 'node',
+      title: 'Node.js',
+      icon: 'javascript',
+    },
+  ],
+};

packages/cli/mocks/configs/code-pushup.config.ts

@@ -0,0 +1,43 @@
+export default {
+  upload: {
+    organization: 'code-pushup',
+    project: 'cli-ts',
+    apiKey: 'e2e-api-key',
+    server: 'https://e2e.com/api',
+  },
+  categories: [
+    {
+      slug: 'category-1',
+      title: 'Category 1',
+      refs: [
+        {
+          type: 'audit',
+          plugin: 'node',
+          slug: 'node-version',
+          weight: 1,
+        },
+      ],
+    },
+  ],
+  plugins: [
+    {
+      audits: [
+        {
+          slug: 'node-version',
+          title: 'Node version',
+          description: 'prints node version to file',
+          docsUrl: 'https://nodejs.org/',
+        },
+      ],
+      runner: {
+        command: 'node',
+        args: ['-v'],
+        outputFile: 'output.json',
+      },
+      groups: [],
+      slug: 'node',
+      title: 'Node.js',
+      icon: 'javascript',
+    },
+  ],
+};

packages/cli/mocks/configs/code-pushup.needs-tsconfig.config.ts

@@ -0,0 +1,8 @@
+// the point is to test runtime import which requires tsconfig for path aliases
+import customPlugin from '@example/custom-plugin';
+
+const config = {
+  plugins: [customPlugin],
+};
+
+export default config;

packages/cli/mocks/configs/custom-plugin.ts

@@ -0,0 +1,24 @@
+const customPluginConfig = {
+  slug: 'good-feels',
+  title: 'Good feels',
+  icon: 'javascript',
+  audits: [
+    {
+      slug: 'always-perfect',
+      title: 'Always perfect',
+    },
+  ],
+  runner: () => [
+    {
+      slug: 'always-perfect',
+      score: 1,
+      value: 100,
+      displayValue: '✅ Perfect! 👌',
+    },
+  ],
+};
+
+export function customPlugin() {
+  return customPluginConfig;
+}
+export default customPluginConfig;

packages/cli/mocks/configs/tsconfig.json

@@ -0,0 +1,11 @@
+{
+  "compilerOptions": {
+    "baseUrl": ".",
+    "allowImportingTsExtensions": true,
+    "moduleResolution": "node",
+    "paths": {
+      "@example/custom-plugin": ["./custom-plugin.ts"]
+    }
+  },
+  "include": ["*.ts"]
+}

packages/cli/mocks/core-config-middleware.int-helper.ts

@@ -0,0 +1,25 @@
+import { coreConfigMiddleware } from '../src/lib/implementation/core-config.middleware.js';
+
+// Suppress all console output except our JSON
+const originalStdoutWrite = process.stdout.write.bind(process.stdout);
+const originalStderrWrite = process.stderr.write.bind(process.stderr);
+
+process.stdout.write = () => true;
+process.stderr.write = () => true;
+
+const CLI_DEFAULTS = {
+  plugins: [],
+  onlyPlugins: [],
+  skipPlugins: [],
+};
+
+const result = await coreConfigMiddleware({
+  config: 'code-pushup.needs-tsconfig.config.ts', // relative path
+  // No tsconfig - should fallback to ./tsconfig.json
+  ...CLI_DEFAULTS,
+});
+
+// Restore stdout and stderr, then write only JSON
+process.stdout.write = originalStdoutWrite;
+process.stderr.write = originalStderrWrite;
+process.stdout.write(JSON.stringify({ success: true, config: result.config }));

packages/cli/src/lib/implementation/core-config.middleware.int.test.ts

@@ -1,5 +1,6 @@
 import path from 'node:path';
 import { fileURLToPath } from 'node:url';
+import { executeProcess } from '@code-pushup/utils';
 import { coreConfigMiddleware } from './core-config.middleware.js';
 
 const configDirPath = path.join(
@@ -8,15 +9,26 @@ const configDirPath = path.join(
   '..',
   '..',
   '..',
-  '..',
-  'testing',
-  'test-fixtures',
-  'src',
-  'lib',
-  'fixtures',
+  'cli',
+  'mocks',
   'configs',
 );
-
+const helperPath = path.join(
+  fileURLToPath(path.dirname(import.meta.url)),
+  '..',
+  '..',
+  '..',
+  '..',
+  'cli',
+  'mocks',
+  'core-config-middleware.int-helper.ts',
+);
+const runMiddlewareInCwd = async () =>
+  await executeProcess({
+    command: 'npx',
+    args: ['tsx', helperPath],
+    cwd: configDirPath,
+  });
 describe('coreConfigMiddleware', () => {
   const CLI_DEFAULTS = {
     plugins: [],
@@ -43,16 +55,14 @@ describe('coreConfigMiddleware', () => {
   });
 
   it('should load config which relies on provided --tsconfig', async () => {
-    await expect(
-      coreConfigMiddleware({
-        config: path.join(
-          configDirPath,
-          'code-pushup.needs-tsconfig.config.ts',
-        ),
-        tsconfig: path.join(configDirPath, 'tsconfig.json'),
-        ...CLI_DEFAULTS,
-      }),
-    ).resolves.toBeTruthy();
+    const { stdout, code } = await runMiddlewareInCwd();
+
+    expect(code).toBe(0);
+    const output = JSON.parse(stdout);
+    expect(output).toStrictEqual({
+      success: true,
+      config: expect.any(String),
+    });
   });
 
   it('should throw if --tsconfig is missing but needed to resolve import', async () => {

packages/utils/src/lib/file-system.int.test.ts

@@ -1,5 +1,3 @@
-import { type CoreConfig } from '@code-pushup/models';
-
 export default {
   upload: {
     organization: 'code-pushup',
@@ -42,4 +40,4 @@ export default {
       icon: 'javascript',
     },
   ],
-} satisfies CoreConfig;
+};