refactor(plugin-typescript): use dynamic tsconfig pattern matching

Author: hanna-skryl

packages/plugin-typescript/mocks/fixtures/nx-monorepo/packages/cli/tsconfig.base.json

@@ -0,0 +1,3 @@
+{
+  "compilerOptions": { "strict": true }
+}

packages/plugin-typescript/mocks/fixtures/nx-monorepo/packages/cli/tsconfig.json

@@ -0,0 +1,5 @@
+{
+  "files": [],
+  "include": [],
+  "references": [{ "path": "./tsconfig.lib.json" }]
+}

packages/plugin-typescript/src/lib/nx/tsconfig-paths.int.test.ts

@@ -37,7 +37,9 @@ describe.skipIf(process.platform === 'win32')('Nx helpers', () => {
   });
 
   describe('tsconfigFromAllNxProjects', () => {
-    it('should find tsconfig.lib.json from all Nx projects', async () => {
+    it('should find tsconfig files, filtering out empty configs and tsconfig.base.json', async () => {
+      // cli project has tsconfig.json (empty arrays, filtered), tsconfig.base.json (excluded), tsconfig.lib.json (included)
+      // other projects only have tsconfig.lib.json
       await expect(tsconfigFromAllNxProjects()).resolves.toEqual([
         'packages/cli/tsconfig.lib.json',
         'packages/core/tsconfig.lib.json',

packages/plugin-typescript/src/lib/nx/tsconfig-paths.ts

@@ -1,18 +1,39 @@
 import type { ProjectConfiguration } from '@nx/devkit';
 import { readdir } from 'node:fs/promises';
 import path from 'node:path';
+import { readConfigFile, sys } from 'typescript';
 import { logger, pluralizeToken, stringifyError } from '@code-pushup/utils';
 import { formatMetaLog } from '../format.js';
 
 /**
- * TypeScript config patterns to look for in each project.
+ * Matches tsconfig.json and tsconfig.*.json, excludes tsconfig.base.json.
  */
-const TSCONFIG_PATTERNS = new Set([
-  'tsconfig.lib.json',
-  'tsconfig.spec.json',
-  'tsconfig.test.json',
-  'tsconfig.app.json',
-]);
+function isTsconfigFile(filename: string): boolean {
+  if (filename === 'tsconfig.base.json') {
+    return false;
+  }
+  return (
+    filename === 'tsconfig.json' ||
+    (filename.startsWith('tsconfig.') && filename.endsWith('.json'))
+  );
+}
+
+/**
+ * Returns false for empty configs (files and include both empty arrays).
+ */
+function hasFilesToCompile(tsconfigPath: string): boolean {
+  const { config } = readConfigFile(tsconfigPath, sys.readFile);
+
+  if (!config) {
+    return true;
+  }
+
+  const { files, include } = config;
+  const filesEmpty = Array.isArray(files) && files.length === 0;
+  const includeEmpty = Array.isArray(include) && include.length === 0;
+
+  return !(filesEmpty && includeEmpty);
+}
 
 /**
  * Resolves the cached project graph for the current Nx workspace.
@@ -40,13 +61,15 @@ function isProjectIncluded(
 }
 
 /**
- * Finds tsconfig files matching known patterns in a project directory.
+ * Finds non-empty tsconfig files in a project directory.
  */
 async function findTsconfigsInProject(projectRoot: string): Promise<string[]> {
   const absoluteRoot = path.resolve(process.cwd(), projectRoot);
   const files = await readdir(absoluteRoot);
+
   return files
-    .filter(file => TSCONFIG_PATTERNS.has(file))
+    .filter(isTsconfigFile)
+    .filter(file => hasFilesToCompile(path.join(absoluteRoot, file)))
     .map(file => path.join(projectRoot, file));
 }
 

packages/plugin-typescript/src/lib/runner/runner.ts

@@ -32,13 +32,17 @@ function collectDiagnostics(tsconfigs: string[]): CollectResult {
   return tsconfigs.reduce<CollectResult>(
     (acc, config) => {
       try {
-        const diagnostics = [
-          ...getTypeScriptDiagnostics({ tsconfig: config }),
-        ].map(diag => ({
-          code: diag.code,
-          issue: getIssueFromDiagnostic(diag),
-        }));
-        return { ...acc, diagnostics: [...acc.diagnostics, ...diagnostics] };
+        const diagnostics = getTypeScriptDiagnostics({ tsconfig: config }).map(
+          diag => ({
+            code: diag.code,
+            issue: getIssueFromDiagnostic(diag),
+          }),
+        );
+
+        return {
+          ...acc,
+          diagnostics: [...acc.diagnostics, ...diagnostics],
+        };
       } catch (error) {
         if (tsconfigs.length === 1) {
           throw error;
@@ -95,7 +99,7 @@ export function createRunnerFunction(options: RunnerOptions): RunnerFunction {
     logger.info(
       diagnostics.length === 0
         ? 'No TypeScript errors found'
-        : `TypeScript compiler found ${pluralizeToken('diagnostic', diagnostics.length)}`,
+        : `TypeScript compiler found ${pluralizeToken('error', diagnostics.length)} in total`,
     );
 
     const result = groupDiagnosticsByAudit(diagnostics);

packages/plugin-typescript/src/lib/runner/ts-runner.ts

@@ -14,15 +14,20 @@ export function getTypeScriptDiagnostics({
   tsconfig,
 }: DiagnosticsOptions): readonly Diagnostic[] {
   const { fileNames, options } = loadTargetConfig(tsconfig);
-  logger.debug(
-    `Parsed TypeScript config file ${tsconfig}, program includes ${pluralizeToken('file', fileNames.length)}`,
-  );
   try {
     const program = createProgram(fileNames, options);
     const diagnostics = getPreEmitDiagnostics(program);
-    logger.debug(
-      `TypeScript compiler found ${pluralizeToken('diagnostic', diagnostics.length)}`,
-    );
+
+    if (diagnostics.length > 0) {
+      logger.info(
+        `  ${tsconfig} - ${pluralizeToken('error', diagnostics.length)}`,
+      );
+    } else {
+      logger.debug(
+        `  ${tsconfig}: ${pluralizeToken('file', fileNames.length)}, 0 errors`,
+      );
+    }
+
     return diagnostics;
   } catch (error) {
     throw new Error(