Move AI Tutor model log to useEffect #67175
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edcodedotorg
changed the title
molly-moen
approved these changes
Jul 17, 2025
| @@ -21,6 +21,10 @@ const AiTutor2Chat: React.FunctionComponent<AiTutor2ChatProps> = ({ | |||
| }) => { | |||
| const dispatch = useAppDispatch(); | |||
|
|
|||
| useEffect(() => { | |||
| console.log('🤖: aiTutorModelId:', aiTutorModelId); | |||
There was a problem hiding this comment.
mind adding a comment explaining this?
There was a problem hiding this comment.
sure and done! I guess it's self explanatory what it's doing but not why. Basically added the PR description as a comment explaining the why.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AI Tutor uses query params to allow AI model selection but otherwise does not provide any user interface to select or see the selected model. A console log was added to give users (testers) feedback as to which model was actually selected (e.g. if the query param is entered incorrectly or an unavailable model is selected, it will default to gemini 2.0 flash).
This PR moves this log from the module that calculates the model ID (from query param or default) to a
useEffectin the highest level AI Tutor component, since the module was being imported even if AI Tutor wasn't enabled, leading to a confusing console log message.Links
This was reported by @molly-moen in slack.
Testing story
This was tested manually and it correctly logs in an AI Tutor enabled level and does not log in a level where AI Tutor is disabled.