Skip to content

Commit 626b74c

Browse files
martinpittjelly
authored andcommitted
test: Reduce dependency on #host-sel button
Drop the mobile check in TestRoles. The same check is already done in TestMenu. Avoid actually opening the host switcher menu in `TestMultiMachine.testDirectLogin`, just check that the nav menu shows that we are logged into the expected machine.
1 parent 497c699 commit 626b74c

File tree

2 files changed

+1
-8
lines changed

2 files changed

+1
-8
lines changed

test/verify/check-shell-multi-machine

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -267,9 +267,7 @@ class TestMultiMachine(testlib.MachineCase):
267267

268268
b.wait_js_cond(f'window.location.pathname == "{root}=10.111.113.2/system"')
269269

270-
b.click("#hosts-sel button")
271-
b.wait_in_text(f"a[href='{root}=10.111.113.2/@localhost']", "machine2")
272-
b.wait_not_present("a[href='/@10.111.113.2']")
270+
b.wait_in_text("#hosts-sel", "machine2")
273271
b.logout()
274272

275273
# Bad host key

test/verify/check-users-roles

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,6 @@ class TestRoles(testlib.MachineCase):
4848
b.enter_page("/system")
4949
b.switch_to_top()
5050
b.wait_text('#current-username', 'user')
51-
b.set_layout("mobile")
52-
b.click("#hosts-sel button")
53-
b.wait_in_text(".view-hosts .pf-m-current", "user @")
54-
b.click("#hosts-sel button")
55-
b.set_layout("desktop")
5651

5752
b.go("/users#/user")
5853
b.enter_page("/users")

0 commit comments

Comments
 (0)