Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: CONTRIBUTING guidelines #8

Open
1 task done
omrishiv opened this issue Jun 12, 2024 · 2 comments
Open
1 task done

Feature: CONTRIBUTING guidelines #8

omrishiv opened this issue Jun 12, 2024 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@omrishiv
Copy link
Contributor

Have you searched for this feature request?

  • I searched but did not find similar requests

Problem Statement

As a newcomer (or a regular committer) it would be great to have contribution guidelines. A set of guidelines for how to structure the new stacks and maybe some example anti-patterns to stay away from would be great.

Possible Solution

Create a CONTRIBUTING.md with some guidance

Alternatives Considered

No response

@omrishiv omrishiv added the enhancement New feature or request label Jun 12, 2024
@nabuskey nabuskey added the help wanted Extra attention is needed label Sep 27, 2024
@nabuskey
Copy link
Contributor

nabuskey commented Sep 27, 2024

Some examples for what we might want in guidelines:

  1. Version pinning if remote helm repos are used.
  2. When to use helm chart vs manifests.
  3. Application Sets vs Applications.
  4. Readme essentials:
    • Overview: What does this do? Why should you care?
    • Optional architecture diagram.
    • Relevant links for further reading.

@cmoulliard
Copy link

I fully agree to have this guide as typically what we are suggesting here has not been implemented for by example the local stack ref implementation.

That means also that we need a PR review process where we check/control if the needed information are well present

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants