Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #22 #46

Merged
merged 3 commits into from
Oct 19, 2023
Merged

fixes #22 #46

merged 3 commits into from
Oct 19, 2023

Conversation

jessesanford
Copy link
Contributor

@jessesanford jessesanford commented Oct 18, 2023

This should fix #22 thanks to @cmoulliard. I simply rebased on our current master.

@jessesanford jessesanford changed the title solves #22 fixes #22 Oct 18, 2023
@jessesanford jessesanford requested a review from nabuskey October 18, 2023 22:07
@nimakaviani nimakaviani self-requested a review October 18, 2023 23:49
Copy link
Contributor

@nimakaviani nimakaviani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessesanford jessesanford merged commit eae6d24 into main Oct 19, 2023
1 of 2 checks passed
@jessesanford jessesanford deleted the issue-22-backstage-svc-and-ingress branch October 19, 2023 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backstage component is not deployed as service and no ingress route is available
3 participants