Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial ssh clone support #405

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

nabuskey
Copy link
Collaborator

Related to: #385

This adds support for cloning private repositories by SSH.

Currently, when users want to use a private repository, they need to first clone the private repository, then run idpbuilder against the local copy. This allows them to specify a private repository with ssh clone format:

idpbuilder  create --recreate  --package [email protected]:nabuskey/stacks-private//basic/package2

Currently only SSH Key authentication without password is supported.

I am not sure about introducing something like this because:

  1. This adds complexity and cannot possibly account for different SSH configurations. e.g. trying all valid ssh keys, accounting for passwords, etc.
  2. There's already a valid workaround. Cloning a private repo with way more reliable git clone command.
  3. In the future, it may introduce support for http auth which becomes even more complex.

Signed-off-by: Manabu McCloskey <[email protected]>
@nabuskey nabuskey requested review from a team, omrishiv, cmoulliard and blakeromano and removed request for a team October 11, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

1 participant