Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Support Overriding CNI #453

Open
1 task done
blakeromano opened this issue Nov 20, 2024 · 2 comments
Open
1 task done

Feature: Support Overriding CNI #453

blakeromano opened this issue Nov 20, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@blakeromano
Copy link
Contributor

Have you searched for this feature request?

  • I searched but did not find similar requests

Problem Statement

I want to be able to use idpbuilder with a CNI of my choice. For example I should be able to override to avoid using the default CNI and use something like cilium https://docs.cilium.io/en/stable/installation/kind/

Possible Solution

We should add a cli argument to idpbuilder that is --cni and if set to something like cilium we should update KIND Config we generate to have:

networking:
  disableDefaultCNI: true

And we should also orchestrate for the CNI to be created (if we don't do this the other pods won't come up, like gitea, etc;)

Alternatives Considered

I mean we could have a generic hook instead to install things outside of the ArgoCD model but I think that is a worse way to do this because ideally we should have very few exceptions to managing things outside of ArgoCD

@blakeromano blakeromano added the enhancement New feature or request label Nov 20, 2024
@nabuskey
Copy link
Collaborator

This would require:

  • Embed cilium manifests.
  • Load images at run time. Pull if necessary.
  • Install.

I agree that CNI is an unique use case because it involves special configuration at bootstrap time and effectively required for other pods to work. Something idpbuilder should support imo.

@blakeromano
Copy link
Contributor Author

I do get concerned about bloatedness of the idpbuilder cli.

I almost wonder if we could make it so there is a special CNOE annotation to apply a package first outside of argocd first, then let Argo take control after initial deployment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants