Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Installation of a core package is blocked if there is a parameter not parsed correctly #446

Open
cmoulliard opened this issue Nov 12, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@cmoulliard
Copy link
Contributor

What is your environment, configuration, and command?

Issue

When we try to customize a resource like the Argocd ConfigMap to add some new data, if one of the data's value is not set using the correct type (see hereafter)

Wrong:

apiVersion: v1
kind: ConfigMap
metadata:
  name: argocd-cm
data:
  application.resourceTrackingMethod: annotation
  admin.enabled: true

Good:

apiVersion: v1
kind: ConfigMap
metadata:
  name: argocd-cm
data:
  admin.enabled: "true"

then idpbuilder hangs and blocks to install a new package.

You will then see as pods: gitea, ingress but not at all argocd !

Remark: Sometimes, you could also get an error as the gitea HTTP response to get the token is nil

[signal SIGSEGV: segmentation violation code=0x2 addr=0x0 pc=0x106394664]

goroutine 1013 [running]:
github.com/cnoe-io/idpbuilder/pkg/controllers/localbuild.getGiteaToken({0x106ce2400, 0x1400055a190}, {0x140010808d0, 0x24}, {0x14000bee224, 0xa}, {0x14000780210, 0x28})
        /Users/cmoullia/code/cnoe/fork-idpbuilder/pkg/controllers/localbuild/gitea.go:189 +0x294
github.com/cnoe-io/idpbuilder/pkg/controllers/localbuild.(*LocalbuildReconciler).setGiteaToken(_, {_, _}, {{{0x10680b702, 0x6}, {0x1063ae33e, 0x2}}, {{0x1400143e780, 0x10}, {0x0, ...}, ...}, ...}, ...)
        /Users/cmoullia/code/cnoe/fork-idpbuilder/pkg/controllers/localbuild/gitea.go:166 +0x198
github.com/cnoe-io/idpbuilder/pkg/controllers/localbuild.(*LocalbuildReconciler).ReconcileGitea(0x140003e57c0, {0x106ce2400, 0x1400055a190}, {{{0x0?, 0x0?}, {0x140006312c0?, 0x5?}}}, 0x14001442c00)
        /Users/cmoullia/code/cnoe/fork-idpbuilder/pkg/controllers/localbuild/gitea.go:132 +0x898
github.com/cnoe-io/idpbuilder/pkg/controllers/localbuild.(*LocalbuildReconciler).installCorePackages.func1()
        /Users/cmoullia/code/cnoe/fork-idpbuilder/pkg/controllers/localbuild/controller.go:118 +0xa8
created by github.com/cnoe-io/idpbuilder/pkg/controllers/localbuild.(*LocalbuildReconciler).installCorePackages in goroutine 1012
        /Users/cmoullia/code/cnoe/fork-idpbuilder/pkg/controllers/localbuild/controller.go:116 +0x340


  tokens, resp, err := giteaClient.ListAccessTokens(gitea.ListAccessTokensOptions{})
  if err != nil {
    return "", fmt.Errorf("listing gitea access tokens. status: %s error : %w", resp.Status, err) // Line 189 !!!!!
  }        

What did you do and What did you see instead?

Version of argocd: >= 0.8

Additional Information. Logs.

No response

@cmoulliard cmoulliard added the bug Something isn't working label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant