[Bug]: idpbuilder don't exit when we apply new packages

[cmoulliard]

What is your environment, configuration, and command?

Issue

idpbuilder don't exit when we apply new packages and continues to log messages even if all the argocd Applications CR have been successfully installed and status are sync + health

idp create \
        --color \
        --name my-konflux \
        --kind-config my-konflux-cfg.yaml \
        -p fork-konflux-ci/idp/secret-plugin \
        -p fork-konflux-ci/idp/github-app-secrets \
        -p fork-konflux-ci/idp/smee \
        -p fork-konflux-ci/idp/image-controller
Nov  8 10:28:26 INFO Creating kind cluster logger=setup
Nov  8 10:28:26 INFO enabling experimental podman provider logger=setup
Nov  8 10:28:26 INFO Cluster already exists logger=setup cluster=my-konflux
Nov  8 10:28:27 INFO Adding CRDs to the cluster logger=setup
Nov  8 10:28:27 INFO Setting up CoreDNS logger=setup
Nov  8 10:28:27 INFO Setting up TLS certificate logger=setup
Nov  8 10:28:27 INFO Creating localbuild resource logger=setup
Nov  8 10:28:27 INFO Starting EventSource controller=localbuild controllerGroup=idpbuilder.cnoe.io controllerKind=Localbuild source=kind source: *v1alpha1.Localbuild
Nov  8 10:28:27 INFO Starting Controller controller=localbuild controllerGroup=idpbuilder.cnoe.io controllerKind=Localbuild
Nov  8 10:28:27 INFO Starting EventSource controller=gitrepository controllerGroup=idpbuilder.cnoe.io controllerKind=GitRepository source=kind source: *v1alpha1.GitRepository
Nov  8 10:28:27 INFO Starting Controller controller=gitrepository controllerGroup=idpbuilder.cnoe.io controllerKind=GitRepository
Nov  8 10:28:27 INFO Starting EventSource controller=custompackage controllerGroup=idpbuilder.cnoe.io controllerKind=CustomPackage source=kind source: *v1alpha1.CustomPackage
Nov  8 10:28:27 INFO Starting Controller controller=custompackage controllerGroup=idpbuilder.cnoe.io controllerKind=CustomPackage
Nov  8 10:28:27 INFO Starting workers controller=gitrepository controllerGroup=idpbuilder.cnoe.io controllerKind=GitRepository worker count=1
Nov  8 10:28:27 INFO Starting workers controller=custompackage controllerGroup=idpbuilder.cnoe.io controllerKind=CustomPackage worker count=1
Nov  8 10:28:27 INFO Starting workers controller=localbuild controllerGroup=idpbuilder.cnoe.io controllerKind=Localbuild worker count=1
Nov  8 10:28:27 INFO unknown field "status.history[0].initiatedBy" logger=KubeAPIWarningLogger
Nov  8 10:28:27 INFO installing bootstrap apps to ArgoCD controller=localbuild controllerGroup=idpbuilder.cnoe.io controllerKind=Localbuild name=my-konflux name=my-konflux reconcileID=0efcbe1e-9a0c-4795-995d-c3772e753f60
Nov  8 10:28:29 INFO Checking if we should shutdown controller=localbuild controllerGroup=idpbuilder.cnoe.io controllerKind=Localbuild name=my-konflux name=my-konflux reconcileID=0efcbe1e-9a0c-4795-995d-c3772e753f60
Nov  8 10:28:30 INFO installing bootstrap apps to ArgoCD controller=localbuild controllerGroup=idpbuilder.cnoe.io controllerKind=Localbuild name=my-konflux name=my-konflux reconcileID=9d0d30b5-145b-4ce1-8e28-4a09e0a36906
Nov  8 10:28:30 INFO Checking if we should shutdown controller=localbuild controllerGroup=idpbuilder.cnoe.io controllerKind=Localbuild name=my-konflux name=my-konflux reconcileID=9d0d30b5-145b-4ce1-8e28-4a09e0a36906
Nov  8 10:28:45 INFO installing bootstrap apps to ArgoCD controller=localbuild controllerGroup=idpbuilder.cnoe.io controllerKind=Localbuild name=my-konflux name=my-konflux reconcileID=6e68dbaf-1f62-4d7a-a544-c027760e4d8d
Nov  8 10:28:45 INFO Checking if we should shutdown controller=localbuild controllerGroup=idpbuilder.cnoe.io controllerKind=Localbuild name=my-konflux name=my-konflux reconcileID=6e68dbaf-1f62-4d7a-a544-c027760e4d8d
Nov  8 10:29:00 INFO installing bootstrap apps to ArgoCD controller=localbuild controllerGroup=idpbuilder.cnoe.io controllerKind=Localbuild name=my-konflux name=my-konflux reconcileID=6b5a8e09-4529-4d7f-be3c-992dde6bea0d
Nov  8 10:29:00 INFO Checking if we should shutdown controller=localbuild controllerGroup=idpbuilder.cnoe.io controllerKind=Localbuild name=my-konflux name=my-konflux reconcileID=6b5a8e09-4529-4d7f-be3c-992dde6bea0d
Nov  8 10:29:16 INFO installing bootstrap apps to ArgoCD controller=localbuild controllerGroup=idpbuilder.cnoe.io controllerKind=Localbuild name=my-konflux name=my-konflux reconcileID=f75d4e72-f43e-43b8-88a1-6b773f5c832f
...
Nov  8 10:37:20 INFO installing bootstrap apps to ArgoCD controller=localbuild controllerGroup=idpbuilder.cnoe.io controllerKind=Localbuild name=my-konflux name=my-konflux reconcileID=a25421d9-2b62-4ecc-bb40-03571d5115cb
Nov  8 10:37:20 INFO Checking if we should shutdown controller=localbuild controllerGroup=idpbuilder.cnoe.io controllerKind=Localbuild name=my-konflux name=my-konflux reconcileID=a25421d9-2b62-4ecc-bb40-03571d5115cb
Nov  8 10:37:36 INFO installing bootstrap apps to ArgoCD controller=localbuild controllerGroup=idpbuilder.cnoe.io controllerKind=Localbuild name=my-konflux name=my-konflux reconcileID=222f9bc3-a8c8-48d3-97f9-e9a1efaaa978
Nov  8 10:37:36 INFO Checking if we should shutdown controller=localbuild controllerGroup=idpbuilder.cnoe.io controllerKind=Localbuild name=my-konflux name=my-konflux reconcileID=222f9bc3-a8c8-48d3-97f9-e9a1efaaa978

What did you do and What did you see instead?

See steps and 2 commands to install the dependencies + cluster followed by install konflux & testing packages

Additional Information. Logs.

No response

[nabuskey]

This happens because we don't know which packages were installed in the previous command. We should just add labels and look them up instead.

[cmoulliard]

We should just add labels and look them up instead.

What do you mean ?