Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion]: Improve some log messages #438

Open
1 task done
cmoulliard opened this issue Nov 8, 2024 · 0 comments
Open
1 task done

[Suggestion]: Improve some log messages #438

cmoulliard opened this issue Nov 8, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@cmoulliard
Copy link
Contributor

cmoulliard commented Nov 8, 2024

Have you searched for this feature request?

  • I searched but did not find similar requests

Problem Statement

Suggestion

Improve some log messages

The following log message is bit crappy !
Nov 8 08:24:49 ERROR Reconciler error controller=localbuild controllerGroup=idpbuilder.cnoe.io controllerKind=Localbuild name=my-konflux name=my-konflux reconcileID=48522f13-2605-46b8-95c8-e614cebebbce err=reconciling bootstrap apps creating argocd repo CR: GitRepository.idpbuilder.cnoe.io "argocd" is invalid: spec.provider.gitURL: Invalid value: "": spec.provider.gitURL in body should match '^https?:\/\/.+$'

The user should get a proper message saying that by example gitea is not yet available and argocd application is not spec compliant as URL of the repo don't exist yet or equivalent

This message make us a bit crazy
INFO Checking if we should shutdown controller=localbuild controllerGroup=[idpbuilder.cnoe.io](http://idpbuilder.cnoe.io/) controllerKind=Localbuild name=my-konflux name=my-konflux reconcileID=9d5dc86a-a739-4f54-a756-2263fc2b9b23
as we have no idea about what idpbuilder is checking ...

Possible Solution

n/A

Alternatives Considered

No response

@cmoulliard cmoulliard added the enhancement New feature or request label Nov 8, 2024
@cmoulliard cmoulliard changed the title Feature: Improve some log messages [Suggestion]: Improve some log messages Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant