Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit the flag name: use-path-routing which is not meaningful #417

Open
cmoulliard opened this issue Oct 17, 2024 · 0 comments
Open

Revisit the flag name: use-path-routing which is not meaningful #417

cmoulliard opened this issue Oct 17, 2024 · 0 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@cmoulliard
Copy link
Contributor

cmoulliard commented Oct 17, 2024 •
edited
Loading

Improvement

The name of the parameter/argument use-path-routing which is used to configure the internal container registry of CRI (and perhaps more) using either the FQDN of gitea or the domain name is not meaningful.

I suggest to rename it to something like --no-fqdn

By the way, the documentation should be reviewed to detail what idp do when this parameter/Argument is selected !!

Originally posted by @cmoulliard in #411 (review)
@nabuskey nabuskey added bug Something isn't working documentation Improvements or additions to documentation labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cmoulliard @nabuskey