Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACTION] Proposal 3 - Collect & Compute #147

Open
AntonioDiTuri opened this issue Dec 11, 2024 · 3 comments
Open

[ACTION] Proposal 3 - Collect & Compute #147

AntonioDiTuri opened this issue Dec 11, 2024 · 3 comments

Comments

@AntonioDiTuri
Copy link
Contributor

AntonioDiTuri commented Dec 11, 2024

This issue details what needs to be done in the collect step.

You can reference the proposal 3 - Metrics section: https://github.com/cncf-tags/green-reviews-tooling/blob/main/docs/proposals/proposal-003-report.md#metrics.

There three substeps:

  1. collect the project metrics
  2. collect the metadata
  3. compute the sci

1. The metrics we will need to collect are

container_cpu_usage_seconds_total
container_memory_rss
container_memory_working_set_bytes

All the metrics should be available in prometheus, and we should be able to collect them with a PromQL query.

2. Collect the metadata

After collecting the metrics we need to collect the metadata: https://github.com/cncf-tags/green-reviews-tooling/blob/main/docs/proposals/proposal-003-report.md#metadata

3. Compute the sci

We can run the PromQL query which is already available using the Prometheus Go Client:

@nikimanoledaki
Copy link
Contributor

This could be done by starting a Prometheus Go client: https://github.com/prometheus/client_golang

@AntonioDiTuri AntonioDiTuri changed the title [ACTION] Proposal 3 - Collect [ACTION] Proposal 3 - Collect & Compute Dec 11, 2024
@qasmi
Copy link

qasmi commented Dec 12, 2024

I would like to work on this issue

@SRF-Audio
Copy link
Contributor

@qasmi I was going to work on part 3 of this task, so let me know if you get assigned this ticket.

Once you've got your structure in place, and then I can create a module for the storage part and fit in with your design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants