Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACTION] Add benchmark_path field to projects.json and pipeline #118

Closed
2 tasks
Tracked by #117
nikimanoledaki opened this issue Aug 7, 2024 · 3 comments · Fixed by #122
Closed
2 tasks
Tracked by #117

[ACTION] Add benchmark_path field to projects.json and pipeline #118

nikimanoledaki opened this issue Aug 7, 2024 · 3 comments · Fixed by #122

Comments

@nikimanoledaki
Copy link
Contributor

nikimanoledaki commented Aug 7, 2024

Part of Proposal-002 - Run the CNCF project benchmark tests as part of the automated pipeline

Task Description

This issue tracks implementing part of proposal 2. So the existing pipeline is extended to call the benchmark workflow defined in the projects.json metadata file.

#121 is related to create the benchmark workflow for Falco

Tasks

  • Add a new benchmark_path field in projects.json.
  • Update the benchmark pipeline workflow to take benchmark_path as an input and call the benchmark workflow using the uses syntax
@nikimanoledaki nikimanoledaki changed the title Add a new benchmark_path field to projects.json Add a new benchmark_path field Aug 9, 2024
@rossf7 rossf7 changed the title Add a new benchmark_path field [ACTION] Add benchmark_path field to projects.json and pipeline Aug 14, 2024
@rossf7 rossf7 added good first issue Good for newcomers help wanted Extra attention is needed labels Aug 28, 2024
@vallss
Copy link
Contributor

vallss commented Aug 29, 2024

I can work on this!

@rossf7 rossf7 removed good first issue Good for newcomers help wanted Extra attention is needed labels Aug 29, 2024
@vallss
Copy link
Contributor

vallss commented Sep 8, 2024

Hi @rossf7, do we have a value for the benchmark_path field inside the project.json? Or we leave it like this?

    "projects": [
        {
            "name": "falco",
            "organization": "falcosecurity",
            "benchmark_path": "",
            "configs": [
                "ebpf",
                "modern-ebpf",
                "kmod"
            ]
        }
    ]

@rossf7
Copy link
Contributor

rossf7 commented Sep 9, 2024

do we have a value for the benchmark_path field inside the project.json? Or we leave it like this?

Hi @vallss not yet, let's leave it blank for now.

Once the workflow is added in #121 we can populate the JSON and integrate both changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants