Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Makefile and GitHub action to stop relying on GOPATH #52

Open
radu-matei opened this issue Feb 13, 2020 · 0 comments
Open

Update Makefile and GitHub action to stop relying on GOPATH #52

radu-matei opened this issue Feb 13, 2020 · 0 comments
Labels
good first issue Good for newcomers

Comments

@radu-matei
Copy link
Member

#47 moved the dependency model used by Signy from dep to Go modules, meaning we don't need to build the project in GOPATH anymore.

However, there are a few places in Makefile where we assume the system that is building the project has set a value for the GOPATH environment variable, for example:

signy/Makefile

Line 42 in 21e031d

curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $(GOPATH)/bin $(GOLANGCI_VERSION)

Note that there is also a go get in the bootstrap target which (I think?) still needs a valid GOBIN location.
We should update the install and bootstrap targets to stop assuming one, and update the GitHub action so we don't set up all the environment variables:

export GOPATH=$HOME/go && export GOBIN=$(go env GOPATH)/bin && export PATH=$PATH:$GOPATH&& export PATH=$PATH:$GOBIN && mkdir -p $GOBIN

@radu-matei radu-matei added the good first issue Good for newcomers label Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant