Merge pull request #21 from cmu-sei/bug-fix

sei-npacheco · web-flow · commit 511b19b691e6 · 2025-11-03T12:13:36.000-05:00
quick required bug fix and version bump
diff --git a/edit_form.php b/edit_form.php
@@ -55,7 +55,6 @@ protected function specific_definition($mform) {
         );
         $mform->setType('config_frameworkid', PARAM_INT);
         $mform->hideIf('config_frameworkid', 'config_viewtype', 'neq', 'learningplan');
-        $mform->addRule('config_frameworkid', get_string('required'), 'required', null, 'client');
 
         $mform->addHelpButton('config_frameworkid', 'config_frameworkid', 'block_crucible');
     }
diff --git a/version.php b/version.php
@@ -42,7 +42,7 @@
 
 defined('MOODLE_INTERNAL') || die;
 
-$plugin->version = 2025103100;
+$plugin->version = 2025110300;
 $plugin->requires  = 2025041400;
 $plugin->component = 'block_crucible';
 $plugin->maturity = MATURITY_ALPHA;

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,6 @@ protected function specific_definition($mform) {`
`55`	`55`	`);`
`56`	`56`	`$mform->setType('config_frameworkid', PARAM_INT);`
`57`	`57`	`$mform->hideIf('config_frameworkid', 'config_viewtype', 'neq', 'learningplan');`
`58`		`- $mform->addRule('config_frameworkid', get_string('required'), 'required', null, 'client');`
`59`	`58`
`60`	`59`	`$mform->addHelpButton('config_frameworkid', 'config_frameworkid', 'block_crucible');`
`61`	`60`	`}`