Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

m56d ammo for m56 cupola #6578

Merged
merged 5 commits into from
Jul 19, 2024
Merged

Conversation

cuberound
Copy link
Contributor

@cuberound cuberound commented Jun 27, 2024

About the pull request

changes ammo of m56 cupola of a tank to m56d ammo rather then normal smartgun ammo. it was leftover propably from some super old smartgun behavior. current ammo was 30 dmg 0 ap with 2 shots per second, for reference m4ra with iff scope has slightly better firerate with 36 dmg 40 ap with ap ammo and 48 dmg with 5 ap with normal ammo and you can hold it in hand not have it mounted on a tank. now it has 35 dmg with 50 ap,

Explain why it's good for the game

with other stats still worse then if you were to move m56d around but it is not COMPLETE trap anymore, you are still better off leaving the tank and carring m56d around but at least it can harm the enemy

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
balance: m56 cupola uses m56d ammo rather then standard sg ammo
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Jun 27, 2024
Copy link
Contributor

github-actions bot commented Jul 8, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 8, 2024
@Drulikar Drulikar added Stale Exempt PR can't go stale and removed Stale beg a maintainer to review your PR labels Jul 14, 2024
@Drulikar
Copy link
Contributor

Stale exempt until reviewed

@Drulikar Drulikar added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Jul 19, 2024
@Drulikar Drulikar marked this pull request as draft July 19, 2024 03:23
@Drulikar Drulikar removed the Stale Exempt PR can't go stale label Jul 19, 2024
@cuberound
Copy link
Contributor Author

damn okey fixed it, it is still weaker then normal m56d but it is stronger then throwing rocks hopefuly

@cuberound cuberound requested a review from Drulikar July 19, 2024 08:37
@cuberound cuberound marked this pull request as ready for review July 19, 2024 08:37
@Drulikar Drulikar added this pull request to the merge queue Jul 19, 2024
Merged via the queue into cmss13-devs:master with commit f335e9a Jul 19, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants