Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Run3 PromptReco] CSCTriggerPrimitivesProducer constructor uses 30 MB / stream #46432

Open
makortel opened this issue Oct 17, 2024 · 8 comments

Comments

@makortel
Copy link
Contributor

makortel commented Oct 17, 2024

Noticed in #46040 (comment) CSCTriggerPrimitivesProducer is an edm::stream EDProducer, and allocates 30 MB / stream. On an 8-thread/stream PromptReco job this means 240 MB.

If every stream would not really need its own copy, the PromptReco memory consumption could be potentially reduced by 210 MB.

In addition of the CSCMotherboard (via CSCTriggerPrimitivesBuilder) holding nearly all the 30 MB / stream memory, the CSCMotherboard::run() results in ~500 k memory allocations per event (~2.4 % of all allocations done during event processing).

@makortel
Copy link
Contributor Author

assign L1Trigger/CSCTriggerPrimitives

@cmsbuild
Copy link
Contributor

New categories assigned: l1

@aloeliger,@epalencia you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 17, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

A new Issue was created by @makortel.

@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

type performance-improvements

@makortel
Copy link
Contributor Author

In addition of the CSCMotherboard (via CSCTriggerPrimitivesBuilder) holding nearly all the 30 MB / stream memory, the CSCMotherboard::run() results in ~500 k memory allocations per event (~2.4 % of all allocations done during event processing).

@makortel
Copy link
Contributor Author

makortel commented Dec 9, 2024

Ping @cms-sw/l1-l2

@makortel
Copy link
Contributor Author

Came up in #46975 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants