-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Run3 PromptReco] CSCTriggerPrimitivesProducer constructor uses 30 MB / stream #46432
Comments
assign L1Trigger/CSCTriggerPrimitives |
New categories assigned: l1 @aloeliger,@epalencia you have been requested to review this Pull request/Issue and eventually sign? Thanks |
cms-bot internal usage |
A new Issue was created by @makortel. @Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
type performance-improvements |
In addition of the |
Ping @cms-sw/l1-l2 |
Came up in #46975 (comment) |
Noticed in #46040 (comment)
CSCTriggerPrimitivesProducer
is anedm::stream
EDProducer, and allocates 30 MB / stream. On an 8-thread/stream PromptReco job this means 240 MB.If every stream would not really need its own copy, the PromptReco memory consumption could be potentially reduced by 210 MB.
In addition of the
CSCMotherboard
(viaCSCTriggerPrimitivesBuilder
) holding nearly all the 30 MB / stream memory, theCSCMotherboard::run()
results in ~500 k memory allocations per event (~2.4 % of all allocations done during event processing).The text was updated successfully, but these errors were encountered: