Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: remove OAuth2ClientConfig.defaults #49

Closed
wants to merge 1 commit into from
Closed

BREAKING: remove OAuth2ClientConfig.defaults #49

wants to merge 1 commit into from

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Sep 27, 2023

Closes #41

@iuioiua iuioiua changed the title BREAKING: flatten OAuth2ClientConfig BREAKING: remove OAuth2ClientConfig.defaults Sep 27, 2023
@iuioiua
Copy link
Contributor Author

iuioiua commented Oct 3, 2023

WDYT, @cmd-johnson?

@cmd-johnson
Copy link
Owner

I'm not quite sure tbh
The defaults property holds data that can be overridden in each request, while the other properties are basically constant between all requests. I feel like promoting e.g. scope to the top level could suggest that that's what's used at all times, while nesting it into defaults makes it obvious that it's just... the default 😅

Not that it would make much of a difference in practice, though 🤷
Anyway, seeing as this would be a breaking change, I'd rather hold off on merging this just yet until the OIDC client (#39) is done

@iuioiua iuioiua closed this by deleting the head repository Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

suggestion: remove OAuth2ClientConfig.defaults
2 participants