Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

id_token support (OpenID) #28

Open
zifeo opened this issue Jun 11, 2023 · 3 comments · May be fixed by #32
Open

id_token support (OpenID) #28

zifeo opened this issue Jun 11, 2023 · 3 comments · May be fixed by #32

Comments

@zifeo
Copy link
Contributor

zifeo commented Jun 11, 2023

Is there a particular reason for this library not to return the id_token when present aside the access and refresh token?

@martpet
Copy link

martpet commented Jun 29, 2023

I was also looking for the ID token today and found it was missing.

@jollytoad jollytoad linked a pull request Jun 29, 2023 that will close this issue
@jollytoad
Copy link

Me too, so I've raised a PR ^

@cmd-johnson
Copy link
Owner

Hi there!
Sorry for the delay here, but as I wrote in #29 (unfortunately without linking back to this issue), I didn't originally intended for this module to be an OpenID Connect client.

Since then, I came to the conclusion that it would probably be best to open up the OAuth2 Grant classes to allow other classes to inherit from them and override or extend their functionality (as would be required for proper OIDC support).
I've also started working on a more proper OIDC client that uses this mechanism to add spec-conformant handling of ID tokens, among other extensions that OIDC makes to the OAuth2 spec.

If you're interested in that, check out my latest comment in #29. Any feedback would be much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants