Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile for durdraw #41

Merged
merged 5 commits into from
Jan 23, 2024
Merged

Dockerfile for durdraw #41

merged 5 commits into from
Jan 23, 2024

Conversation

yumpyy
Copy link
Contributor

@yumpyy yumpyy commented Jan 23, 2024

Added a Dockerfile for durdraw. closes #22

-i and -t flags are required in docker run command for proper functioning of durdraw

@cmang
Copy link
Owner

cmang commented Jan 23, 2024

This is awesome. Thank you for making this file!

I am still a bit Docker dumb, and had a couple of thoughts.

1: Would it be better to have it use Python 3.10 or higher? This should allow it to use the mouse "wheel" scrolling.

2: Is Alpine the best base to use here? I have read that it builds pip dependencies from source and does not support binary wheels, resulting in oversized containers. Maybe this has changed, or I misunderstood? (edit: The only dependency is Pillow. Not sure if it applies here.) Reference

Edit edit: If Alpine is the right thing to use here, awesome. That reference is a bit old now and may have obsolete information.

Thanks!

@yumpyy
Copy link
Contributor Author

yumpyy commented Jan 23, 2024

Hi!

  1. I will change python version to 12
  2. My reason for choosing alpine is the smaller image size and faster build time than slim (only a 1sec difference in building) so I think alpine is better in this case...if you want I can change python image to the debian-slim one.
    Image size comparison

@cmang
Copy link
Owner

cmang commented Jan 23, 2024

1: Sweet! I usually dev on 3.11.
2: Sounds like Alpine is the way to go. My apologies for the newb questions. Currently doing some docker crash coursing.

I'll be testing and merging this soon. Thanks, @yumpyy!

@cmang cmang merged commit 9174e3a into cmang:master Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker run
2 participants