Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUPPORT_DEVICE my GRII omits "RICOH" #3

Open
epadepa opened this issue Aug 2, 2019 · 3 comments
Open

SUPPORT_DEVICE my GRII omits "RICOH" #3

epadepa opened this issue Aug 2, 2019 · 3 comments

Comments

@epadepa
Copy link

epadepa commented Aug 2, 2019

I had to remove the RICOH string from the SUPPORT_DEVICE to get my GRII with 3.0 firmware to work. SUPPORT_DEVICE = ['GR II', 'RICOH GR III']

@clyang
Copy link
Owner

clyang commented Aug 29, 2019

Can you elaborate on this issue with more detail please?

@johnmaguire
Copy link

Just wanted to chime in and say I don't have a GR II but I'm not sure how this script would work with it...

  1. DEVICE defaults to "RICOH GR II" - https://github.com/clyang/GRsync/blob/master/GRsync.py#L24
  2. DEVICE is overridden and set to props["model"] but must be one of ['RICOH GR II', 'RICOH GR III'] - https://github.com/clyang/GRsync/blob/master/GRsync.py#L173-L178
  3. The non-GR III route is used only if DEVICE is "GR2" (this should be == but regardless it's not clear how this would ever be set to "GR2") - https://github.com/clyang/GRsync/blob/master/GRsync.py#L91-L94

I don't have a GR II to test with, just perusing this code for a project of my own. I believe @epadepa was stating that his props["model"] on his camera is set to GR II which isn't allowed due to the check in step #2 above.

Even after the change @epadepa made, it'd be using the "GR III route" - which is likely the same for any GR device on a newer firmware.

@vardai
Copy link

vardai commented Jan 16, 2022

My GR II also refers to itself as "GR II" rather than "RICOH GR II", thus the script comes to a halt before even starting any transfer at all. Firmware is 3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants