Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement WriterExt for Writer<&mut BytesMut> #147

Closed
qRoC opened this issue Dec 28, 2024 · 1 comment · Fixed by #148
Closed

Implement WriterExt for Writer<&mut BytesMut> #147

qRoC opened this issue Dec 28, 2024 · 1 comment · Fixed by #148

Comments

@qRoC
Copy link
Contributor

qRoC commented Dec 28, 2024

One of the patterns of using BytesMut is to use it in signatures like:

fn write(&self, out: &mut BytesMut)

So, out.writer() is Writer<&mut BytesMut>
@liuq19
Copy link
Collaborator

liuq19 commented Dec 29, 2024

ok, could you PR for that

@qRoC qRoC mentioned this issue Dec 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: impl WriteExt for &mut BytesMut qRoC/sonic-rs
2 participants
@qRoC @liuq19