Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Implement statement separator without spansql to fix parse errors #83

Open
apstndb opened this issue Mar 10, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@apstndb
Copy link

apstndb commented Mar 10, 2023

WHAT

There is a motivation to replace spansql with a more primitive implementation.
I want to discuss it.

WHY

Currently, wrench can't process statements which are not supported by spansql because of the spansql dependency.

spansql is used in ddlToStatements, dmlToStatements.
https://github.com/cloudspannerecosystem/wrench/blob/v1.4.1/pkg/spanner/migration.go#L144-L170

spansql is not actively maintained by Google and not 100% compatible with Cloud Spanner DDL/DML so the dependency on spansql makes it complex for wrench to support the new features of Cloud Spanner.

Reference

@apstndb apstndb added the enhancement New feature or request label Mar 10, 2023
@apstndb apstndb changed the title Proposal: Implement statement parser without spansql Proposal: Implement statement separator without spansql Mar 10, 2023
@apstndb apstndb mentioned this issue Mar 10, 2023
1 task
@apstndb apstndb changed the title Proposal: Implement statement separator without spansql Proposal: Implement statement separator without spansql to fix parse errors Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant