Accepter incorrectly maps routes to subnets

[mattcasiro]

Found a bug? Maybe our Slack Community can help.

Describe the Bug

When calculating the local value accepter_aws_rt_map the try condition always fails to default because it's attempting to access a set value using an index which is not possible.

Expected Behavior

The try condition properly accesses the set values when available to correctly build the map.

Steps to Reproduce

Steps to reproduce the behavior:

1. Create a VPC with multiple route tables attached to different subnets as the accepter
2. Run the terraform module with accepted and requester
3. See that only one route table is mapped to the peering connection

Screenshots

If applicable, add screenshots or logs to help explain your problem.

Environment (please complete the following information):

Anything that will help us triage the bug will help. Here are some ideas:

• Terraform Version 0.13
• AWS Provider Version 4.0

Additional Context

Wrapping the set value in "tolist()" should resolve this, but I have yet to fully validate this solution.

[mattcasiro]

Upgrading from tf 0.13 to tf 0.14 seems to have fixed this, as a workaround. I can't find the actual documentation that explains why this would be the case though, so there's a chance I'm missing something.

[mattcasiro]

Correction on the above. The actual fix was the upgrade from AWS provider 3.x to 4.x. In provider 3.x the ids attribute on the aws_route_tables data source is a set. On 4.x it's a list. This is why adding tolist() should resolve it, providing backwards compatibility.