-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add homebrew custom tap #1849
Add homebrew custom tap #1849
Conversation
This reverts commit d2f2652.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nitrocode @osterman I haven't finished my review, but so far, I think we should:
- Enable/disable Homebrew formulae the way we enable/disable
rpm
packages - Not publish formulae that duplicate those maintained in
homebrew/core
(with the possible exception ofatmos
) - Probably not publish formulae for the few packages we compile (e.g.
terraform-config-inspect
) because it is too much work to set up the formulae to have the right dependencies to build on the target host - Either don't publish or come up with a better strategy for installing/naming the version-pinned packages like
kubectl-1.18
Also, as far as I have seen so far, there is nothing checking these formulae into git
/GitHub. Perhaps we should create a Homebrew tap repo (cloudposse/homebrew-tap
) and update it from the release build or have it update itself.
Will get to this eventually. I'll close for now until this is a priority. |
what
install
target in the vendored packageMakefile
notable changes for reviewers
packages/.github/package-template.yml
Lines 223 to 229 in 5f2f989
why
references
commands
Eventually, it will be easy as this
For now, after running the above command, the correct branch will also have to be checked out
brew install cloudposse/packages/atmos
generate formula